Issue 26467005: Revert "Fixing timezone issues with date-time/parse-* tests."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26467005: Revert "Fixing timezone issues with date-time/parse-* tests." (Closed)

Created:
7 years, 2 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 2 months ago

Reviewers:
titzer, Nebojša Ćirić, cira

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Fixing timezone issues with date-time/parse-* tests." This reverts commit r17148 for breaking tests on Windows. TBR=cira@google.com,titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17149

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -104 lines)			Patch
M	src/i18n.js	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/intl/date-format/parse-MMMdy.js	View	1 chunk	+6 lines, -9 lines	0 comments	Download
M	test/intl/date-format/parse-mdy.js	View	1 chunk	+15 lines, -17 lines	0 comments	Download
M	test/intl/date-format/parse-mdyhms.js	View	1 chunk	+8 lines, -14 lines	0 comments	Download
D	test/intl/date-format/timezone-name.js	View	1 chunk	+0 lines, -53 lines	0 comments	Download
A +	test/intl/date-format/utils.js	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	test/intl/testcfg.py	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

Committed patchset #1 manually as r17149.

7 years, 2 months ago (2013-10-10 19:43:13 UTC) #1

Nebojša Ćirić

7 years, 2 months ago (2013-10-10 19:45:52 UTC) #2

Message was sent while issue was closed.

On 2013/10/10 19:43:13, Dmitry Lomov (chromium) wrote:
> Committed patchset #1 manually as r17149.

lgtm

Thanks. I was just sending a follow up CL to fix the issue.

Expand Messages | Collapse Messages