Add LayoutTest for GlobalEventHandlers

Add LayoutTest for GlobalEventHandlers

BUG=305112
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159116

[philipj_slow, 2013-10-08 09:13:13]

The presubmit was not impressed with FAIL in the expected results, but having
this seems useful to me, as the test then must be updated when the bugs are
fixed. If that's not acceptable, I could comment out the failing bits instead.

[jochen (gone - plz use gerrit), 2013-10-08 12:22:37]

lgtm with nit

https://codereview.chromium.org/26467002/diff/1/LayoutTests/fast/dom/global-e...
File LayoutTests/fast/dom/global-event-handlers.html (right):

https://codereview.chromium.org/26467002/diff/1/LayoutTests/fast/dom/global-e...
LayoutTests/fast/dom/global-event-handlers.html:69: function nop() {}
nit. 4 spaces indent in blink

[commit-bot: I haz the power, 2013-10-08 12:56:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/26467002/6001

[commit-bot: I haz the power, 2013-10-08 13:56:19]

Change committed as 159116

[abarth-chromium, 2013-10-09 05:54:49]

On 2013/10/08 09:13:13, philipj wrote:
> The presubmit was not impressed with FAIL in the expected results, but having
> this seems useful to me, as the test then must be updated when the bugs are
> fixed. If that's not acceptable, I could comment out the failing bits instead.

What error message did it give you?  We check in failing expectations all the
time.

[philipj_slow, 2013-10-09 09:05:31]

On 2013/10/09 05:54:49, abarth wrote:
> On 2013/10/08 09:13:13, philipj wrote:
> > The presubmit was not impressed with FAIL in the expected results, but
having
> > this seems useful to me, as the test then must be updated when the bugs are
> > fixed. If that's not acceptable, I could comment out the failing bits
instead.
> 
> What error message did it give you?  We check in failing expectations all the
> time.

** Presubmit Warnings **
Some test expectations you updated contain "FAIL". Ideally, that wouldn't be the
case. Please verify that these are in fact intentionally failing results, and
not simply oversight.
      LayoutTests/fast/dom/lobal-event-handlers-expected.txt:18 FAIL Set
element.oncancel assert_equals: Initially null expected null but got undefined \

And so on... But it kindly asked if I was sure, and I was, so I guess there is
no problem.

[abarth-chromium, 2013-10-10 03:46:23]

On 2013/10/09 09:05:31, philipj wrote:
> On 2013/10/09 05:54:49, abarth wrote:
> > On 2013/10/08 09:13:13, philipj wrote:
> > > The presubmit was not impressed with FAIL in the expected results, but
> having
> > > this seems useful to me, as the test then must be updated when the bugs
are
> > > fixed. If that's not acceptable, I could comment out the failing bits
> instead.
> > 
> > What error message did it give you?  We check in failing expectations all
the
> > time.
> 
> ** Presubmit Warnings **
> Some test expectations you updated contain "FAIL". Ideally, that wouldn't be
the
> case. Please verify that these are in fact intentionally failing results, and
> not simply oversight.
>       LayoutTests/fast/dom/lobal-event-handlers-expected.txt:18 FAIL Set
> element.oncancel assert_equals: Initially null expected null but got undefined
\
> 
> And so on... But it kindly asked if I was sure, and I was, so I guess there is
> no problem.

I would track down what generated that message and ask whoever added it if we
should remove it.  It seems like a silly warning.

[philipj_slow, 2013-10-10 07:26:56]

It was added very recently:

https://src.chromium.org/viewvc/blink?revision=158264&view=revision

Looks like there was some skepticism when it was added as well.