third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp - Issue 2646633002: IntersectionObserver: remove gc-timing-revealing execeptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp

Issue 2646633002: IntersectionObserver: remove gc-timing-revealing execeptions. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions-expected.txt ('k') | third_party/WebKit/Source/core/dom/IntersectionObservation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp

diff --git a/third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp b/third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp

index ff76561d108f5432782ddc8e31edde18daa8eee8..d7b55909112f4058549be17e3f2c087aa877eb1f 100644

--- a/third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp

+++ b/third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp

@@ -33,8 +33,9 @@ void ElementIntersectionObserverData::removeObserver(

void ElementIntersectionObserverData::addObservation(

IntersectionObservation& observation) {

+ DCHECK(observation.observer());

m_intersectionObservations.add(

- TraceWrapperMember<IntersectionObserver>(this, &observation.observer()),

+ TraceWrapperMember<IntersectionObserver>(this, observation.observer()),

&observation);

}