ShowCreatedWindow: some speculative fixes for 680876.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <stddef.h>
 
 #include <cmath>
 #include <utility>
@@ skipping 2098 matching lines @@
       WebContentsView* new_view = new_contents->view_.get();
 
       // TODO(brettw): It seems bogus that we have to call this function on the
       // newly created object and give it one of its own member variables.
       new_view->CreateViewForWidget(
           new_contents->GetRenderViewHost()->GetWidget(), false);
     }
     // Save the created window associated with the route so we can show it
     // later.
     DCHECK_NE(MSG_ROUTING_NONE, main_frame_widget_route_id);
+    CHECK(RenderWidgetHostImpl::FromID(render_process_id,
+                                       main_frame_widget_route_id));
     pending_contents_[std::make_pair(
         render_process_id, main_frame_widget_route_id)] = new_contents;
     AddDestructionObserver(new_contents);
   }
 
   if (delegate_) {
     delegate_->WebContentsCreated(
         this, render_process_id, params.opener_render_frame_id,
         params.frame_name, params.target_url, new_contents);
   }
@@ skipping 80 matching lines @@
 }
 
 void WebContentsImpl::ShowCreatedWindow(int process_id,
                                         int main_frame_widget_route_id,
                                         WindowOpenDisposition disposition,
                                         const gfx::Rect& initial_rect,
                                         bool user_gesture) {
   WebContentsImpl* contents =
       GetCreatedWindow(process_id, main_frame_widget_route_id);
   if (contents) {
+    RenderWidgetHostImpl* rwh =
+        RenderWidgetHostImpl::FromID(process_id, main_frame_widget_route_id);
+    if (!rwh) {
+      // TODO(nick): Temporary for https://crbug.com/680876
+      base::debug::DumpWithoutCrashing();
+      return;
+    }
+
     WebContentsDelegate* delegate = GetDelegate();
     contents->is_resume_pending_ = true;
     if (!delegate || delegate->ShouldResumeRequestsForCreatedWindow())
       contents->ResumeLoadingCreatedWebContents();
 
     if (delegate) {
       delegate->AddNewContents(this, contents, disposition, initial_rect,
                                user_gesture, NULL);
     }
 
-    RenderWidgetHostImpl* rwh = contents->GetMainFrame()->GetRenderWidgetHost();
-    DCHECK_EQ(main_frame_widget_route_id, rwh->GetRoutingID());
     rwh->Send(new ViewMsg_Move_ACK(rwh->GetRoutingID()));
   }
 }
 
 void WebContentsImpl::ShowCreatedWidget(int process_id,
                                         int route_id,
                                         const gfx::Rect& initial_rect) {
   ShowCreatedWidget(process_id, route_id, false, initial_rect);
 }
 
@@ skipping 3178 matching lines @@
   GetMainFrame()->AddMessageToConsole(
       content::CONSOLE_MESSAGE_LEVEL_WARNING,
       base::StringPrintf("This site does not have a valid SSL "
                          "certificate! Without SSL, your site's and "
                          "visitors' data is vulnerable to theft and "
                          "tampering. Get a valid SSL certificate before"
                          " releasing your website to the public."));
 }
 
 }  // namespace content