Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 26466003: IDL compiler: [CustomElementCallbacks] for getter + cleanup values (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix Perl Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index 12de7e5f89da407c6387d8782764f2c0819c1820..febcd983101190e685b9440d7e9b68af87cd7693 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -1727,15 +1727,8 @@ sub GenerateCustomElementInvocationScopeIfNeeded
{
my $code = "";
my $ext = shift;
- my $annotation = $ext->{"CustomElementCallbacks"} || "";
- if ($annotation eq "None") {
- # Explicit CustomElementCallbacks=None overrides any other
- # heuristic.
- return $code;
- }
-
- if ($annotation eq "Enable" or $ext->{"Reflect"}) {
+ if ($ext->{"CustomElementCallbacks"} or $ext->{"Reflect"}) {
AddToImplIncludes("core/dom/custom/CustomElementCallbackDispatcher.h");
$code .= <<END;
CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;

Powered by Google App Engine
This is Rietveld 408576698