Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 26466003: IDL compiler: [CustomElementCallbacks] for getter + cleanup values (Closed)

Created:
7 years, 2 months ago by Nils Barth (inactive)
Modified:
7 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, kojih, jsbell+bindings_chromium.org, webcomponents-bugzilla_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, do-not-use, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: [CustomElementCallbacks] for getter + cleanup values [CustomElementCallbacks] is only ever called as [CustomElementCallbacks=Enable], so the value is redundant. This changes it to not take an argument. Also the Perl CG has cruft from when 'Disable' was called 'None'; this decrufts it. This also adds a test case to TestObjectPython.idl, though since this extended attribute doesn't affect getters, no Python CG changes are needed; will do when we do setters. Doc: https://sites.google.com/a/chromium.org/dev/blink/webidl/blink-idl-extended-attributes#TOC-CustomElementCallbacks-m-a- BUG=239771 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159218

Patch Set 1 #

Patch Set 2 : Fix Perl #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -86 lines) Patch
M Source/bindings/scripts/IDLAttributes.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/code_generator_v8.pm View 1 1 chunk +1 line, -8 lines 0 comments Download
M Source/bindings/tests/idls/TestObjectPython.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 2 chunks +14 lines, -0 lines 2 comments Download
M Source/core/dom/Attr.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ChildNode.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMTokenList.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/Document.idl View 6 chunks +11 lines, -11 lines 0 comments Download
M Source/core/dom/Element.idl View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/NamedNodeMap.idl View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Node.idl View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Range.idl View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDocument.idl View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLElement.idl View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/html/HTMLFormElement.idl View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLInputElement.idl View 2 chunks +13 lines, -13 lines 0 comments Download
M Source/core/page/Selection.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XSLTProcessor.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nils Barth (inactive)
Mostly Perl CG/IDL extended attribute fixes. (No Python CG changes, just test.)
7 years, 2 months ago (2013-10-08 11:01:54 UTC) #1
haraken
https://codereview.chromium.org/26466003/diff/3001/Source/bindings/tests/results/V8TestObjectPython.cpp File Source/bindings/tests/results/V8TestObjectPython.cpp (right): https://codereview.chromium.org/26466003/diff/3001/Source/bindings/tests/results/V8TestObjectPython.cpp#newcode845 Source/bindings/tests/results/V8TestObjectPython.cpp:845: static void customElementsCallbacksReadonlyLongAttributeAttributeGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info) Is this ...
7 years, 2 months ago (2013-10-08 11:06:51 UTC) #2
Nils Barth (inactive)
https://codereview.chromium.org/26466003/diff/3001/Source/bindings/tests/results/V8TestObjectPython.cpp File Source/bindings/tests/results/V8TestObjectPython.cpp (right): https://codereview.chromium.org/26466003/diff/3001/Source/bindings/tests/results/V8TestObjectPython.cpp#newcode845 Source/bindings/tests/results/V8TestObjectPython.cpp:845: static void customElementsCallbacksReadonlyLongAttributeAttributeGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info) On 2013/10/08 ...
7 years, 2 months ago (2013-10-09 00:43:36 UTC) #3
haraken
Thanks for clarification. LGTM.
7 years, 2 months ago (2013-10-09 00:46:20 UTC) #4
Nils Barth (inactive)
On 2013/10/09 00:46:20, haraken wrote: > Thanks for clarification. LGTM. n/p, committing!
7 years, 2 months ago (2013-10-09 00:50:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/26466003/3001
7 years, 2 months ago (2013-10-09 00:50:54 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 11:09:18 UTC) #7
Message was sent while issue was closed.
Change committed as 159218

Powered by Google App Engine
This is Rietveld 408576698