Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2646493003: Disable npm steps on DDC bot for now (Closed)

Created:
3 years, 11 months ago by vsm
Modified:
3 years, 11 months ago
Reviewers:
Leaf, Bill Hesse
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable npm steps on DDC bot for now This will only regression test compilation (no running of generated code), but that appears to work. R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/b2b7975d635eea81fc370f07758564a7e28d3e65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/bots/ddc_tests.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 11 months ago (2017-01-18 23:28:06 UTC) #3
Leaf
lgtm
3 years, 11 months ago (2017-01-18 23:29:52 UTC) #4
vsm
3 years, 11 months ago (2017-01-18 23:30:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b2b7975d635eea81fc370f07758564a7e28d3e65 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698