third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp - Issue 2646493002: '*' is not a valid attribute selector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

Issue 2646493002: '*' is not a valid attribute selector (Closed)

Patch Set: Adjust serialization test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

index 221797dff6d4a53bbf842a89442dedd7eca8807f..6de81c9678ca37942f584890d5f617da8a48b3d8 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp

@@ -375,6 +375,8 @@ std::unique_ptr<CSSParserSelector> CSSSelectorParser::consumeAttribute(

AtomicString attributeName;

if (!consumeName(block, attributeName, namespacePrefix))

return nullptr;

+ if (attributeName == starAtom)

+ return nullptr;

block.consumeWhitespace();

if (m_context->isHTMLDocument())