Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: runtime/vm/object_store.cc

Issue 2646443005: Track async causal stack traces (Closed)
Patch Set: Chain stack traces together Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object_store.cc
diff --git a/runtime/vm/object_store.cc b/runtime/vm/object_store.cc
index e35ed7aebfe8bda3c0f74ce5b44240b81c8405bc..ace11afeb7d7c5aeb4c1f910fadba062f460b183 100644
--- a/runtime/vm/object_store.cc
+++ b/runtime/vm/object_store.cc
@@ -9,6 +9,7 @@
#include "vm/isolate.h"
#include "vm/object.h"
#include "vm/raw_object.h"
+#include "vm/resolver.h"
#include "vm/symbols.h"
#include "vm/visitor.h"
@@ -93,6 +94,8 @@ ObjectStore::ObjectStore()
simple_instance_of_function_(Function::null()),
simple_instance_of_true_function_(Function::null()),
simple_instance_of_false_function_(Function::null()),
+ async_clear_thread_stack_trace_(Function::null()),
+ async_set_thread_stack_trace_(Function::null()),
library_load_error_table_(Array::null()),
unique_dynamic_targets_(Array::null()),
token_objects_(GrowableObjectArray::null()),
@@ -237,6 +240,25 @@ void ObjectStore::InitKnownObjects() {
ASSERT(!cls.IsNull());
set_stream_iterator_class(cls);
siva 2017/02/08 18:46:29 You could also set up generic string and function
Cutch 2017/02/09 22:45:51 Done.
+ const String& async_set_thread_stack_trace_private_name = String::Handle(
+ async_lib.PrivateName(Symbols::SetAsyncThreadStackTrace()));
+ ASSERT(!async_set_thread_stack_trace_private_name.IsNull());
+ const Function& async_set_thread_stack_trace =
+ Function::Handle(Resolver::ResolveStatic(
+ async_lib, String::ZoneHandle(String::null()),
siva 2017/02/08 18:46:29 Object::null_string(),
Cutch 2017/02/09 22:45:51 Done.
+ async_set_thread_stack_trace_private_name, 1, Object::null_array()));
+ set_async_set_thread_stack_trace(async_set_thread_stack_trace);
+
+ const String& async_clear_thread_stack_trace_private_name = String::Handle(
+ async_lib.PrivateName(Symbols::ClearAsyncThreadStackTrace()));
+ ASSERT(!async_clear_thread_stack_trace_private_name.IsNull());
+ const Function& async_clear_thread_stack_trace = Function::Handle(
+ Resolver::ResolveStatic(async_lib, String::ZoneHandle(String::null()),
siva 2017/02/08 18:46:29 Object::null_string(),
Cutch 2017/02/09 22:45:51 Done.
+ async_clear_thread_stack_trace_private_name, 0,
+ Object::null_array()));
+ ASSERT(!async_clear_thread_stack_trace.IsNull());
+ set_async_clear_thread_stack_trace(async_clear_thread_stack_trace);
+
const Library& internal_lib = Library::Handle(_internal_library());
cls = internal_lib.LookupClass(Symbols::Symbol());
set_symbol_class(cls);

Powered by Google App Engine
This is Rietveld 408576698