Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2646363005: VM: Tell lsan about mmap()ed regions used for our heap (Closed)

Created:
3 years, 11 months ago by kustermann
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Tell lsan about mmap()ed regions used for our heap The mmap()ed pages hold pointers to `VirtualMemory` objects. So we tell lsan that the mmap()ed regions are roots. R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/a9fbe2004d3f1978930fdb837e2e10f4e88b9013

Patch Set 1 #

Total comments: 1

Patch Set 2 : status file, only make lsan root region for header #

Patch Set 3 : Mark Dart2JSCompilerStats/Dart2JSCompileAll as Crash, Fail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -11 lines) Patch
M runtime/platform/address_sanitizer.h View 1 chunk +22 lines, -0 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/pages.cc View 1 3 chunks +10 lines, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kustermann
3 years, 11 months ago (2017-01-23 14:26:19 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 11 months ago (2017-01-23 14:40:56 UTC) #3
zra
https://codereview.chromium.org/2646363005/diff/1/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://codereview.chromium.org/2646363005/diff/1/runtime/vm/pages.cc#newcode8 runtime/vm/pages.cc:8: #include "platform/address_sanitizer.h" DBC: alphabetize.
3 years, 11 months ago (2017-01-23 16:58:58 UTC) #5
kustermann
Updated cl.
3 years, 11 months ago (2017-01-24 10:57:56 UTC) #7
kustermann
Committed patchset #3 (id:60001) manually as a9fbe2004d3f1978930fdb837e2e10f4e88b9013 (presubmit successful).
3 years, 11 months ago (2017-01-24 11:47:44 UTC) #9
Vyacheslav Egorov (Google)
3 years, 11 months ago (2017-01-24 12:14:53 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698