Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: src/ast/ast.cc

Issue 2646333002: [parser] Delete has_seen_proto in ObjectLiteral. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/ast.h ('k') | src/parsing/parser-base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast.cc
diff --git a/src/ast/ast.cc b/src/ast/ast.cc
index 3aa7c99cf646018ae2f20617ab8efce68025eefe..d56ef0fbfeb8bf43457d31537ec62922709a12eb 100644
--- a/src/ast/ast.cc
+++ b/src/ast/ast.cc
@@ -520,7 +520,6 @@ void ObjectLiteral::InitDepthAndFlags() {
for (int i = 0; i < properties()->length(); i++) {
ObjectLiteral::Property* property = properties()->at(i);
if (!IsBoilerplateProperty(property)) {
- DCHECK(has_seen_proto());
is_simple = false;
continue;
}
@@ -584,9 +583,14 @@ void ObjectLiteral::BuildConstantProperties(Isolate* isolate) {
if (!constant_properties_.is_null()) return;
int index_keys = 0;
+ bool has_seen_proto = false;
for (int i = 0; i < properties()->length(); i++) {
ObjectLiteral::Property* property = properties()->at(i);
- if (!IsBoilerplateProperty(property) || property->is_computed_name()) {
+ if (!IsBoilerplateProperty(property)) {
+ has_seen_proto = true;
+ continue;
+ }
+ if (property->is_computed_name()) {
continue;
}
@@ -601,7 +605,7 @@ void ObjectLiteral::BuildConstantProperties(Isolate* isolate) {
Handle<BoilerplateDescription> constant_properties =
isolate->factory()->NewBoilerplateDescription(
boilerplate_properties_, properties()->length() - index_keys,
- has_seen_proto());
+ has_seen_proto);
int position = 0;
for (int i = 0; i < properties()->length(); i++) {
« no previous file with comments | « src/ast/ast.h ('k') | src/parsing/parser-base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698