Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4592)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTab.java

Issue 2646313005: Implement additional parts of the new ui for CBD. (Closed)
Patch Set: fix review issues Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTab.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTab.java
new file mode 100644
index 0000000000000000000000000000000000000000..3eb86b9f84e2188ea99172a004aaef6357d58f41
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTab.java
@@ -0,0 +1,61 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.preferences.privacy;
+
+import android.os.Bundle;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.widget.Button;
+
+import org.chromium.chrome.R;
+
+/**
+ * The base class for a clear browsing data tab.
+ */
+public class ClearBrowsingDataPreferencesTab extends ClearBrowsingDataPreferences {
+ @Override
+ public View onCreateView(
+ LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
+ // Replace default preference view with a view with a footer.
Theresa 2017/01/27 03:30:11 There are some extra words in this sentence.
Theresa 2017/01/27 03:31:45 Or maybe there aren't? This may be more clear if i
dullweber 2017/01/30 11:36:44 thanks, that sounds better
+ View view = inflater.inflate(R.layout.clear_browsing_data_tab_content, container, false);
+
+ Button clearButton = (Button) view.findViewById(R.id.clear_button);
+ clearButton.setOnClickListener(new View.OnClickListener() {
+ @Override
+ public void onClick(View v) {
+ onClearButtonClicked();
+ }
+ });
+
+ return view;
+ }
+
+ @Override
+ protected int getPreferenceXmlId() {
+ return R.xml.clear_browsing_data_preferences_tab;
+ }
+
+ @Override
+ protected void initButtonPreference() {
+ // This view has a Button instead of a ButtonPreference. The Button can only be initialized
+ // while or after onCreateView was called.
+ }
+
+ @Override
+ protected void initFootnote() {
+ // This view doesn't have a footnote.
+ }
+
+ @Override
+ protected void updateButtonState() {
+ // The clear button in this view is part of the footer, so it can't be a PreferenceButton
+ // like the clear button in ClearBrowsingDataPreferences. This makes it necessary to have a
+ // different listener and a different method to disable the button.
+ Button clearButton = (Button) getView().findViewById(R.id.clear_button);
+ boolean isEnabled = !getSelectedOptions().isEmpty();
+ clearButton.setEnabled(isEnabled);
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698