Implement additional parts of the new ui for CBD.

chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTab.java

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTab.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTab.java
new file mode 100644
index 0000000000000000000000000000000000000000..b0fb35d4ea3b16d38101208bf89acdc9a45f64ec
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTab.java
@@ -0,0 +1,45 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.preferences.privacy;
+
+import android.os.Bundle;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.widget.Button;
+
+import org.chromium.chrome.R;
+
+/**
+ * The base class for a clear browsing data tab.
+ */
+public class ClearBrowsingDataPreferencesTab extends ClearBrowsingDataPreferences {
+    @Override
+    public View onCreateView(
+            LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
+        // Replace default preference view with a view with a footer.
+        View view = inflater.inflate(R.layout.clear_browsing_data_tab_content, container, false);
+
+        Button clearButton = (Button) view.findViewById(R.id.clear_button);
+        clearButton.setOnClickListener(new View.OnClickListener() {
+            @Override
+            public void onClick(View v) {
+                onClearButtonClicked();
+            }
+        });
+
+        return view;
+    }
+
+    protected int getPreferencesXml() {

[msramek, 2017/01/25 15:24:23]

@Override Here and below.

[dullweber, 2017/01/25 17:22:06]

Done.

+        return R.xml.clear_browsing_data_preferences_in_tab;
+    }
+
+    protected void updateButtonState() {

[msramek, 2017/01/25 15:24:23]

This method should do the same thing in all preferences - why do we need to
redefine it here?

[dullweber, 2017/01/25 17:22:06]

The current dialog is using a ButtonPreference that is part of the ListView
defined in the R.xml.* file. The new dialog uses a button in the footer. The
only way I found to implement this was to create a custom layout for the
preference site with an actual Button that works differently from the
ButtonPreference. So I need the  setOnClickListener and the updateButtonState()
method in this class to make the button work. I'm not sure if it would be
cleaner if I make a copy of ClearBrowsingDataPreference instead of lots
overrides. What do you think?

[msramek, 2017/01/26 11:04:07]

As discussed offline - let's not overcomplicate this and keep your current
implementation where the button is once a normal Button and once a Preference.
But please add a comment explaining what led us to this discrepancy.

+        Button clearButton = (Button) getView().findViewById(R.id.clear_button);
+        boolean isEnabled = !getSelectedOptions().isEmpty();
+        clearButton.setEnabled(isEnabled);
+    }
+}