chrome/android/java/res/layout/preference_spinner_one_line.xml - Issue 2646313005: Implement additional parts of the new ui for CBD.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/preference_spinner_one_line.xml

Issue 2646313005: Implement additional parts of the new ui for CBD. (Closed)

Patch Set: fix review issues Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/clear_browsing_data_tab_content.xml ('K') | « chrome/android/java/res/layout/preference_spinner.xml ('k') | chrome/android/java/res/values-v17/styles.xml » ('j') | chrome/android/java/res/values-v17/styles.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	Theresa 2017/01/27 03:30:11 nit: make this preference_spinner_single_line.xml nit: make this preference_spinner_single_line.xml to match the attribute name dullweber 2017/01/30 11:36:44 Done. Show quoted text On 2017/01/27 03:30:11, Theresa wrote: > nit: make this preference_spinner_single_line.xml to match the attribute name Done.
	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.
	Theresa 2017/01/27 03:30:11 s/2016/2017 s/2016/2017 dullweber 2017/01/30 11:36:44 Done. Show quoted text On 2017/01/27 03:30:11, Theresa wrote: > s/2016/2017 Done.
	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <!-- Layout used by SpinnerPreference if its singleLine is set to true. -->

	7

	8 <RelativeLayout

	9 xmlns:android="http://schemas.android.com/apk/res/android"

	10 style="@style/PreferenceLayout"

	11 android:layout_width="match_parent"

	12 android:layout_height="wrap_content">

	13

	14 <TextView

	15 android:id="@+id/title"

	16 style="@style/PreferenceTitle"

	17 android:textAlignment="viewStart"

	18 android:layout_height="wrap_content"

	19 android:layout_width="wrap_content"

	20 android:layout_centerVertical="true"

	21 android:layout_alignParentStart="true"

	22 android:layout_toStartOf="@id/spinner" />

	23

	24 <Spinner

	25 android:id="@+id/spinner"

	26 android:layout_height="wrap_content"

	27 android:layout_width="wrap_content"

	28 android:layout_centerVertical="true"

	29 android:layout_alignParentEnd="true" />

	30 </RelativeLayout>

OLD	NEW