Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2646313003: Cleanup build_sdk error checking (Closed)

Created:
3 years, 11 months ago by vsm
Modified:
3 years, 11 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M pkg/dev_compiler/tool/build_sdk.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/dev_compiler/tool/build_sdk.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
vsm
3 years, 11 months ago (2017-01-23 13:37:43 UTC) #2
Jennifer Messerly
lgtm!
3 years, 11 months ago (2017-01-23 21:55:17 UTC) #3
vsm
3 years, 11 months ago (2017-01-23 21:56:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9964772025668bc3dc2fc31e75c4b9c70336301b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698