Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: ui/display/display_snapshot_mojo.h

Issue 2646213002: Write mojom and StructTraits for DisplaySnapshot. (Closed)
Patch Set: Add Clone() for DisplaySnapShotMojo and refactor unit test. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef UI_DISPLAY_DISPLAY_SNAPSHOT_MOJO_H_
6 #define UI_DISPLAY_DISPLAY_SNAPSHOT_MOJO_H_
7
kylechar 2017/02/15 16:48:45 Add include for unique_ptr. #include <memory>
thanhph 2017/02/16 11:48:21 Done.
8 #include "base/macros.h"
9 #include "ui/display/display_export.h"
10 #include "ui/display/types/display_snapshot.h"
11
12 namespace display {
13
14 // DisplaySnapshot implementation that can be used with Mojo IPC.
15 class DISPLAY_EXPORT DisplaySnapshotMojo : public DisplaySnapshot {
16 public:
17 DisplaySnapshotMojo(int64_t display_id,
18 const gfx::Point& origin,
19 const gfx::Size& physical_size,
20 DisplayConnectionType type,
21 bool is_aspect_preserving_scaling,
22 bool has_overscan,
23 bool has_color_correction_matrix,
24 std::string display_name,
25 const base::FilePath& sys_path,
26 int64_t product_id,
27 DisplayModeList modes,
28 const std::vector<uint8_t>& edid,
29 const DisplayMode* current_mode,
30 const DisplayMode* native_mode,
31 const gfx::Size& maximum_cursor_size);
32 ~DisplaySnapshotMojo() override;
33 virtual std::unique_ptr<DisplaySnapshotMojo> Clone() const;
kylechar 2017/02/15 16:48:45 Why is this virtual?
thanhph 2017/02/16 11:48:20 Is there other class that will implement DisplaySn
kylechar 2017/02/16 14:05:42 Virtual only works for subclasses. Putting a virtu
34
35 // DisplaySnapshot:
36 std::string ToString() const override;
37
38 private:
39 DISALLOW_COPY_AND_ASSIGN(DisplaySnapshotMojo);
40 };
41
42 } // namespace display
43
44 #endif // UI_DISPLAY_DISPLAY_SNAPSHOT_MOJO_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698