Write mojom and StructTraits for DisplaySnapshot.

ui/display/mojo/display_snapshot_mojo_struct_traits.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_DISPLAY_MOJO_DISPLAY_SNAPSHOT_MOJO_STRUCT_TRAITS_H_
+#define UI_DISPLAY_MOJO_DISPLAY_SNAPSHOT_MOJO_STRUCT_TRAITS_H_
+
+#include "ui/display/display_snapshot_mojo.h"
+#include "ui/display/mojo/display_snapshot_mojo.mojom.h"
+#include "ui/display/types/display_mode.h"
+
+namespace mojo {
+
+template <>
+struct StructTraits<display::mojom::DisplaySnapshotMojoDataView,
+                    std::unique_ptr<display::DisplaySnapshotMojo>> {
+  static int64_t display_id(const std::unique_ptr<display::DisplaySnapshotMojo>&
+                                display_snapshot_mojo) {

[kylechar, 2017/02/14 21:35:28]

optional nit: If you named your parameter |snapshot| you could fit more on one
line.

[thanhph1, 2017/02/15 15:37:56]

Done.

+    return display_snapshot_mojo->display_id();
+  }
+
+  static const gfx::Point& origin(
+      const std::unique_ptr<display::DisplaySnapshotMojo>&
+          display_snapshot_mojo) {
+    return display_snapshot_mojo->origin();
+  }
+
+  static const gfx::Size& physical_size(
+      const std::unique_ptr<display::DisplaySnapshotMojo>&
+          display_snapshot_mojo) {
+    return display_snapshot_mojo->physical_size();
+  }
+
+  static display::DisplayConnectionType type(
+      const std::unique_ptr<display::DisplaySnapshotMojo>&
+          display_snapshot_mojo) {
+    return display_snapshot_mojo->type();
+  }
+
+  static bool is_aspect_preserving_scaling(
+      const std::unique_ptr<display::DisplaySnapshotMojo>&
+          display_snapshot_mojo) {
+    return display_snapshot_mojo->is_aspect_preserving_scaling();
+  }
+
+  static bool has_overscan(const std::unique_ptr<display::DisplaySnapshotMojo>&
+                               display_snapshot_mojo) {
+    return display_snapshot_mojo->has_overscan();
+  }
+
+  static bool has_color_correction_matrix(
+      const std::unique_ptr<display::DisplaySnapshotMojo>&
+          display_snapshot_mojo) {
+    return display_snapshot_mojo->has_color_correction_matrix();
+  }
+
+  static std::string display_name(
+      const std::unique_ptr<display::DisplaySnapshotMojo>&
+          display_snapshot_mojo) {
+    return display_snapshot_mojo->display_name();
+  }
+
+  static const base::FilePath& sys_path(
+      const std::unique_ptr<display::DisplaySnapshotMojo>&
+          display_snapshot_mojo) {
+    return display_snapshot_mojo->sys_path();
+  }
+
+  static std::vector<uint8_t> edid(
+      const std::unique_ptr<display::DisplaySnapshotMojo>&
+          display_snapshot_mojo) {
+    return display_snapshot_mojo->edid();
+  }
+
+  static std::vector<std::unique_ptr<display::DisplayMode>> modes(
+      const std::unique_ptr<display::DisplaySnapshotMojo>&
+          display_snapshot_mojo);
+
+  static uint64_t current_mode_index(
+      const std::unique_ptr<display::DisplaySnapshotMojo>&
+          display_snapshot_mojo);
+
+  // True if display_snapshot_mojo->current_mode() is not null.
+  static bool has_current_mode(
+      const std::unique_ptr<display::DisplaySnapshotMojo>&
+          display_snapshot_mojo) {
+    return display_snapshot_mojo->current_mode();

[kylechar, 2017/02/14 21:35:28]

Instad of your comment you could just do the following and it would be self
documenting.

return display_snapshot_mojo->current_mode() != nullptr;

What happens if display_snapshot_mojo->current_mode() isn't null but it points
to something that isn't contained in display_snapshot->modes() though?

[thanhph1, 2017/02/15 15:37:56]

Done.

+  }
+
+  static uint64_t native_mode_index(
+      const std::unique_ptr<display::DisplaySnapshotMojo>&
+          display_snapshot_mojo);
+
+  // True if display_snapshot_mojo->native_mode() is not null.
+  static bool has_native_mode(
+      const std::unique_ptr<display::DisplaySnapshotMojo>&
+          display_snapshot_mojo) {
+    return display_snapshot_mojo->native_mode();
+  }
+
+  static int64_t product_id(const std::unique_ptr<display::DisplaySnapshotMojo>&
+                                display_snapshot_mojo) {
+    return display_snapshot_mojo->product_id();
+  }
+
+  static const gfx::Size& maximum_cursor_size(
+      const std::unique_ptr<display::DisplaySnapshotMojo>&
+          display_snapshot_mojo) {
+    return display_snapshot_mojo->maximum_cursor_size();
+  }
+
+  static bool Read(display::mojom::DisplaySnapshotMojoDataView data,
+                   std::unique_ptr<display::DisplaySnapshotMojo>* out);
+};
+
+}  // namespace mojo
+
+#endif  // UI_DISPLAY_MOJO_DISPLAY_SNAPSHOT_MOJO_STRUCT_TRAITS_H_