Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: ui/display/types/display_mode.h

Issue 2646213002: Write mojom and StructTraits for DisplaySnapshot. (Closed)
Patch Set: fix format/comments. Refactor structure/code. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_DISPLAY_TYPES_DISPLAY_MODE_H_ 5 #ifndef UI_DISPLAY_TYPES_DISPLAY_MODE_H_
6 #define UI_DISPLAY_TYPES_DISPLAY_MODE_H_ 6 #define UI_DISPLAY_TYPES_DISPLAY_MODE_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <ostream> 9 #include <ostream>
10 #include <string> 10 #include <string>
11 11
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "ui/display/types/display_types_export.h" 13 #include "ui/display/types/display_types_export.h"
14 #include "ui/gfx/geometry/size.h" 14 #include "ui/gfx/geometry/size.h"
15 15
16 namespace display { 16 namespace display {
17 17
18 // This class represents the basic information for a native mode. Platforms will 18 // This class represents the basic information for a native mode. Platforms will
19 // extend this class to add platform specific information about the mode. 19 // extend this class to add platform specific information about the mode.
20 class DISPLAY_TYPES_EXPORT DisplayMode { 20 class DISPLAY_TYPES_EXPORT DisplayMode {
21 public: 21 public:
22 DisplayMode(const gfx::Size& size, bool interlaced, float refresh_rate); 22 DisplayMode(const gfx::Size& size, bool interlaced, float refresh_rate);
23 virtual ~DisplayMode(); 23 virtual ~DisplayMode();
24 virtual std::unique_ptr<DisplayMode> Clone() const; 24 virtual std::unique_ptr<DisplayMode> Clone() const;
25 25
26 const gfx::Size& size() const { return size_; } 26 const gfx::Size& size() const { return size_; }
27 bool is_interlaced() const { return is_interlaced_; } 27 bool is_interlaced() const { return is_interlaced_; }
28 float refresh_rate() const { return refresh_rate_; } 28 float refresh_rate() const { return refresh_rate_; }
29 29 bool operator==(const DisplayMode& display_mode) const;
kylechar 2017/02/13 22:01:24 The parameter is typically named |other| here, in
kylechar 2017/02/13 22:01:24 You should always define operator=! if you define
thanhph1 2017/02/14 20:20:54 Nice, thanks!
thanhph1 2017/02/14 20:20:54 Done.
30 virtual std::string ToString() const; 30 virtual std::string ToString() const;
31 31
32 private: 32 private:
33 gfx::Size size_; 33 gfx::Size size_;
34 bool is_interlaced_; 34 bool is_interlaced_;
35 float refresh_rate_; 35 float refresh_rate_;
36 36
37 DISALLOW_COPY_AND_ASSIGN(DisplayMode); 37 DISALLOW_COPY_AND_ASSIGN(DisplayMode);
38 }; 38 };
39 39
40 // Used to by gtest to print readable errors. 40 // Used to by gtest to print readable errors.
41 DISPLAY_TYPES_EXPORT void PrintTo(const DisplayMode& mode, std::ostream* os); 41 DISPLAY_TYPES_EXPORT void PrintTo(const DisplayMode& mode, std::ostream* os);
42 42
43 } // namespace display 43 } // namespace display
44 44
45 #endif // UI_DISPLAY_TYPES_DISPLAY_MODE_H_ 45 #endif // UI_DISPLAY_TYPES_DISPLAY_MODE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698