ui/display/mojo/display_snapshot.mojom - Issue 2646213002: Write mojom and StructTraits for DisplaySnapshot.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/display/mojo/display_snapshot.mojom

Issue 2646213002: Write mojom and StructTraits for DisplaySnapshot. (Closed)

Patch Set: use FILE_PATH_LITERAL to create base::FilePath::StringType Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ui/display/mojo/display_mode_struct_traits.cc ('K') | « ui/display/mojo/display_mode_struct_traits.cc ('k') | ui/display/mojo/display_snapshot.typemap » ('j') | ui/display/mojo/display_snapshot_mojo.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module display.mojom;

	6

	7 import "ui/gfx/geometry/mojo/geometry.mojom";

	8 import "ui/display/mojo/display_constants.mojom";

	9 import "ui/display/mojo/display_mode.mojom";

	10

	11 // Corresponds to display::DisplaySnapshot

	12 struct DisplaySnapshot {

	13 int64 display_id;

	14 gfx.mojom.Point origin;

	15 gfx.mojom.Size physical_size;

	16 DisplayConnectionType type;

	17 bool is_aspect_preserving_scaling;

	18 bool has_overscan;

	19 bool has_color_correction_matrix;

	20 string display_name;

	21 string sys_path;

	22 array<display.mojom.DisplayMode> modes;

	23 array<uint8> edid;

	24 bool has_current_mode;

	25 display.mojom.DisplayMode current_mode;
	kylechar 2017/02/09 15:05:53 bool + DisplayMode takes more memory than an int32 bool + DisplayMode takes more memory than an int32. Please fix. thanhph1 2017/02/10 19:54:32 I removed this file. Show quoted text On 2017/02/09 15:05:53, kylechar wrote: > bool + DisplayMode takes more memory than an int32. Please fix. I removed this file.
	26 bool has_native_mode;

	27 display.mojom.DisplayMode native_mode;

	28 int64 product_id;

	29 string string_representation;
	kylechar 2017/02/09 15:05:53 This isn't part of display::DispalySnapshot and is This isn't part of display::DispalySnapshot and isn't necessary. thanhph1 2017/02/10 19:54:32 Done, I removed maximum_cursor_size also. Show quoted text On 2017/02/09 15:05:53, kylechar wrote: > This isn't part of display::DispalySnapshot and isn't necessary. Done, I removed maximum_cursor_size also.
	30 gfx.mojom.Size maximum_cursor_size;

	31 };

OLD	NEW