ui/display/mojo/display_constants.mojom - Issue 2646213002: Write mojom and StructTraits for DisplaySnapshot.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/display/mojo/display_constants.mojom

Issue 2646213002: Write mojom and StructTraits for DisplaySnapshot. (Closed)

Patch Set: use FILE_PATH_LITERAL to create base::FilePath::StringType Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module display.mojom;

	6

	7 // Video output types.
	kylechar 2017/02/09 15:05:53 Say what non-mojom enum type this corresponds to. Say what non-mojom enum type this corresponds to. thanhph1 2017/02/10 19:54:31 Done, I put a comment in. Show quoted text On 2017/02/09 15:05:53, kylechar wrote: > Say what non-mojom enum type this corresponds to. Done, I put a comment in.
	8 enum DisplayConnectionType {

	9 DISPLAY_CONNECTION_TYPE_NONE = 0,

	10 DISPLAY_CONNECTION_TYPE_UNKNOWN = 1,

	11 DISPLAY_CONNECTION_TYPE_INTERNAL = 2,

	12 DISPLAY_CONNECTION_TYPE_VGA = 4,

	13 DISPLAY_CONNECTION_TYPE_HDMI = 8,

	14 DISPLAY_CONNECTION_TYPE_DVI = 16,

	15 DISPLAY_CONNECTION_TYPE_DISPLAYPORT = 32,

	16 DISPLAY_CONNECTION_TYPE_NETWORK = 64,

	17 DISPLAY_CONNECTION_TYPE_VIRTUAL = 128,

	18

	19 // Update this when adding a new type.

	20 DISPLAY_CONNECTION_TYPE_LAST = DISPLAY_CONNECTION_TYPE_VIRTUAL
	kylechar 2017/02/09 15:05:53 This isn't necessary/wanted here. This type is onl This isn't necessary/wanted here. This type is only used as a wire format, so you're not going to comparing things against display::mojom::DISPLAY_CONNECTION_TYPE_LAST. thanhph1 2017/02/10 19:54:31 Done. Show quoted text On 2017/02/09 15:05:53, kylechar wrote: > This isn't necessary/wanted here. This type is only used as a wire format, so > you're not going to comparing things against > display::mojom::DISPLAY_CONNECTION_TYPE_LAST. Done.
	21 };

OLD	NEW

« no previous file with comments | « ui/display/mojo/BUILD.gn ('k') | ui/display/mojo/display_constants.typemap » ('j') | ui/display/mojo/display_constants_struct_traits.cc » ('J')