Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 264613005: Change the way libc++ is linked when use_custom_libcxx=1. (Closed)

Created:
6 years, 7 months ago by earthdok
Modified:
6 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Change the way libc++ is linked when use_custom_libcxx=1. Instead of passing libc++.so and libc++abi.so on the command line to the linker, we want to be able to simply pass -stdlib=libc++ to the clang driver and let it make the decision about linking the DSOs. In this way we can avoid linking libc++ into C executables. To this effect we introduce a proxy target which adds -stdlib=libc++ to direct dependents' flags but does not link the actual DSO. We also link libc++abi statically into libc++. The latter change is necessary because clang's -stdlib=libc++ mode is set up to use libsupc++ as the ABI implementation, and will not automatically pick up libc++abi.so. BUG=318770 R=glider@chromium.org, thakis@chromium.org NOTRY=true TEST=msan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268169

Patch Set 1 #

Patch Set 2 : nuke commented lines #

Total comments: 1

Patch Set 3 : s/L/l #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -45 lines) Patch
M base/base.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M build/common.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/libc++/libc++.gyp View 1 2 3 chunks +41 lines, -20 lines 0 comments Download
M third_party/libc++abi/libc++abi.gyp View 1 2 chunks +1 line, -21 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
earthdok
ptal Nico - /base/ + FYI on the security issue in libc++.gyp Alex - everything ...
6 years, 7 months ago (2014-04-30 17:25:43 UTC) #1
Alexander Potapenko
Looks reasonable lgtm https://codereview.chromium.org/264613005/diff/20001/third_party/libc++/libc++.gyp File third_party/libc++/libc++.gyp (right): https://codereview.chromium.org/264613005/diff/20001/third_party/libc++/libc++.gyp#newcode51 third_party/libc++/libc++.gyp:51: # Libc++abi is linked statically into ...
6 years, 7 months ago (2014-04-30 18:18:38 UTC) #2
Nico
lgtm
6 years, 7 months ago (2014-04-30 18:19:20 UTC) #3
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 7 months ago (2014-05-05 11:45:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/264613005/30001
6 years, 7 months ago (2014-05-05 11:45:33 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 13:30:49 UTC) #6
Message was sent while issue was closed.
Change committed as 268169

Powered by Google App Engine
This is Rietveld 408576698