Use ConnectEx on Windows, to do async connect of sockets.

runtime/bin/socket_win.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_WINDOWS)
 
 #include "bin/builtin.h"
 #include "bin/eventhandler.h"
 #include "bin/file.h"
@@ skipping 110 matching lines @@
     return NULL;
   }
   *port = SocketAddress::GetAddrPort(&raw);
   // Clear the port before calling WSAAddressToString as WSAAddressToString
   // includes the port in the formatted string.
   SocketAddress::SetAddrPort(&raw, 0);
   return new SocketAddress(&raw.addr);
 }
 
 
 intptr_t Socket::Create(RawAddr addr) {

[Søren Gjesse, 2014/05/01 07:19:26]

Rename this to CreateBind to match the naming.

[Anders Johnsen, 2014/05/01 08:05:11]

That would force a rename on all platforms, which is not true then. It's an
implementation detail on Windows.

[Søren Gjesse, 2014/05/01 09:42:38]

Sure. We might want to add separate bind on all platforms at some point to have
connect use a user-specified network interface.

[Anders Johnsen, 2014/05/01 10:48:31]

Moving to Connect.

   SOCKET s = socket(addr.ss.ss_family, SOCK_STREAM, 0);
   if (s == INVALID_SOCKET) {
     return -1;
   }
 
   linger l;
   l.l_onoff = 1;
   l.l_linger = 10;
   int status = setsockopt(s,
                           SOL_SOCKET,
                           SO_LINGER,
                           reinterpret_cast<char*>(&l),
                           sizeof(l));
   if (status != NO_ERROR) {
     FATAL("Failed setting SO_LINGER on socket");
   }
 
+  if (addr.ss.ss_family == AF_INET) {
+    struct sockaddr_in a;
+    memset(&a, 0, sizeof(a));
+    a.sin_family = AF_INET;
+    a.sin_addr.s_addr = INADDR_ANY;
+    a.sin_port = 0;
+    status = bind(s, reinterpret_cast<SOCKADDR*>(&a), sizeof(a));
+  } else {
+    struct sockaddr_in6 a;
+    memset(&a, 0, sizeof(a));
+    a.sin6_family = AF_INET6;
+    a.sin6_addr = in6addr_any;
+    a.sin6_port = 0;
+    status = bind(s, reinterpret_cast<SOCKADDR*>(&a), sizeof(a));
+  }

[Søren Gjesse, 2014/05/01 07:19:26]

Can't you use the same code as is used for the other bind calls?

  status = bind(s,
                &addr->addr,
                SocketAddress::GetAddrLength(addr));

[Anders Johnsen, 2014/05/01 08:05:11]

Done.

+  if (status != NO_ERROR) {

[Søren Gjesse, 2014/05/01 07:19:26]

This should not be fatal.

[Anders Johnsen, 2014/05/01 08:05:11]

Done.

+    FATAL("Failed binding socket");
+  }
+
   ClientSocket* client_socket = new ClientSocket(s);
   return reinterpret_cast<intptr_t>(client_socket);
 }
 
 
 intptr_t Socket::Connect(intptr_t fd, RawAddr addr, const intptr_t port) {
   ASSERT(reinterpret_cast<Handle*>(fd)->is_socket());
-  SocketHandle* handle = reinterpret_cast<SocketHandle*>(fd);
+  ClientSocket* handle = reinterpret_cast<ClientSocket*>(fd);
   SOCKET s = handle->socket();
   SocketAddress::SetAddrPort(&addr, port);
-  int status = connect(s, &addr.addr, SocketAddress::GetAddrLength(&addr));
-  if (status == SOCKET_ERROR) {
-    DWORD rc = WSAGetLastError();
-    ClientSocket* client_socket = reinterpret_cast<ClientSocket*>(fd);
-    client_socket->Close();
-    SetLastError(rc);
-    return -1;
+
+  LPFN_CONNECTEX connectEx = NULL;
+  GUID guid_connect_ex = WSAID_CONNECTEX;
+  DWORD bytes;
+  int status = WSAIoctl(s,

[Søren Gjesse, 2014/05/01 07:19:26]

Are you sure you cannot just load this once like it is done with AcceptEx?

[Anders Johnsen, 2014/05/01 08:05:11]

No, it's using the socket as an argument. Also, it's done per-socket for
AcceptEx as well.

[Søren Gjesse, 2014/05/01 09:42:38]

Of cause you are right.

+                        SIO_GET_EXTENSION_FUNCTION_POINTER,
+                        &guid_connect_ex,
+                        sizeof(guid_connect_ex),
+                        &connectEx,
+                        sizeof(connectEx),
+                        &bytes,
+                        NULL,
+                        NULL);
+  DWORD rc;
+  if (status != SOCKET_ERROR) {
+    handle->EnsureInitialized(EventHandler::delegate());
+
+    OverlappedBuffer* overlapped = OverlappedBuffer::AllocateConnectBuffer();
+
+    status = connectEx(s,
+                       &addr.addr,
+                       SocketAddress::GetAddrLength(&addr),
+                       NULL,
+                       0,
+                       NULL,
+                       overlapped->GetCleanOverlapped());
+
+
+    if (status == TRUE) {
+      handle->ConnectComplete(overlapped);
+      return fd;
+    } else if (WSAGetLastError() == ERROR_IO_PENDING) {
+      return fd;
+    }
+    rc = WSAGetLastError();
+    // Cleanup in case of error.
+    OverlappedBuffer::DisposeBuffer(overlapped);
+  } else {
+    rc = WSAGetLastError();
   }
-  return fd;
+  handle->Close();
+  delete handle;
+  SetLastError(rc);
+  return -1;
 }
 
 
 intptr_t Socket::CreateConnect(RawAddr addr, const intptr_t port) {
   intptr_t fd = Socket::Create(addr);
   if (fd < 0) {
     return fd;
   }
 
   return Socket::Connect(fd, addr, port);
@@ skipping 469 matching lines @@
                     proto,
                     MCAST_LEAVE_GROUP,
                     reinterpret_cast<char *>(&mreq),
                     sizeof(mreq)) == 0;
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_WINDOWS)