Precompiler: Rehash types after reassigning class ids.

Precompiler: Rehash types after reassigning class ids.

R=asiva@google.com, regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/0040deb15ca7b16fdf5bb0732aca363d5edced1d

[rmacnak, 2017-01-20 17:28:27]

rmacnak@google.com changed reviewers:
+ asiva@google.com, regis@google.com

[rmacnak, 2017-01-20 17:28:28]

rmacnak@google.com changed reviewers:
+ asiva@google.com, regis@google.com

[siva, 2017-01-20 18:37:02]

lgtm

https://codereview.chromium.org/2646073005/diff/1/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/2646073005/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:2652: }
Should we also be clearing the hash value for IsMixinAppType() ?

[regis, 2017-01-20 19:21:58]

lgtm

https://codereview.chromium.org/2646073005/diff/1/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/2646073005/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:2652: }
On 2017/01/20 18:37:02, siva wrote:
> Should we also be clearing the hash value for IsMixinAppType() ?

As soon as the super type of a class is resolved, the MixinAppType is replaced
by a set of synthesized mixin application classes. A MixinAppType should never
be seen while snapshotting (unless we snapshot still unresolved classes). In any
case, they do not cash or even compute their hash.

[regis, 2017-01-20 19:21:59]

lgtm

https://codereview.chromium.org/2646073005/diff/1/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/2646073005/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:2652: }
On 2017/01/20 18:37:02, siva wrote:
> Should we also be clearing the hash value for IsMixinAppType() ?

As soon as the super type of a class is resolved, the MixinAppType is replaced
by a set of synthesized mixin application classes. A MixinAppType should never
be seen while snapshotting (unless we snapshot still unresolved classes). In any
case, they do not cash or even compute their hash.

[rmacnak, 2017-01-20 20:13:12]

https://codereview.chromium.org/2646073005/diff/1/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/2646073005/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:2652: }
On 2017/01/20 19:21:59, regis wrote:
> On 2017/01/20 18:37:02, siva wrote:
> > Should we also be clearing the hash value for IsMixinAppType() ?
> 
> As soon as the super type of a class is resolved, the MixinAppType is replaced
> by a set of synthesized mixin application classes. A MixinAppType should never
> be seen while snapshotting (unless we snapshot still unresolved classes). In
any
> case, they do not cash or even compute their hash.

Removed hash_ from RawMixinAppType

[rmacnak, 2017-01-20 20:13:54]

Description was changed from

==========
Precompiler: Rehash types after reassigning class ids.
==========

to

==========
Precompiler: Rehash types after reassigning class ids.

R=asiva@google.com, regis@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0040deb15ca7b16fdf5bb0732aca363d5edced1d
==========

[rmacnak, 2017-01-20 20:13:55]

Committed patchset #2 (id:20001) manually as
0040deb15ca7b16fdf5bb0732aca363d5edced1d (presubmit successful).