Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sandbox/win/sandbox_poc/main_ui_window.cc

Issue 2646043002: Reland "Fix sandbox::PolicyBase leak" (Closed)
Patch Set: updated and fix jobless bug Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/sandbox_win.cc ('k') | sandbox/win/src/broker_services.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/sandbox_poc/main_ui_window.cc
diff --git a/sandbox/win/sandbox_poc/main_ui_window.cc b/sandbox/win/sandbox_poc/main_ui_window.cc
index 4ca6b07f25a3bc14b6acbc5d0b53b9875c3e2817..8576faeb759a123818fb06f83e56a91d06c4d6aa 100644
--- a/sandbox/win/sandbox_poc/main_ui_window.cc
+++ b/sandbox/win/sandbox_poc/main_ui_window.cc
@@ -500,7 +500,7 @@ bool MainUIWindow::SpawnTarget() {
arguments[size_call - 1] = L'\0';
- sandbox::TargetPolicy* policy = broker_->CreatePolicy();
+ scoped_refptr<sandbox::TargetPolicy> policy = broker_->CreatePolicy();
policy->SetJobLevel(sandbox::JOB_LOCKDOWN, 0);
policy->SetTokenLevel(sandbox::USER_RESTRICTED_SAME_ACCESS,
sandbox::USER_LOCKDOWN);
@@ -519,7 +519,6 @@ bool MainUIWindow::SpawnTarget() {
broker_->SpawnTarget(spawn_target_.c_str(), arguments, policy,
&warning_result, &last_error, &target_);
- policy->Release();
policy = NULL;
bool return_value = false;
« no previous file with comments | « content/common/sandbox_win.cc ('k') | sandbox/win/src/broker_services.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698