Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2646033003: DevTools: streamline console logging levels, migrate 'log' to 'info' level, 'debug' to 'verbose' le… (Closed)
Patch Set: missing rebaseline Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 0ab358f06eb7dcc20666cde8805407294848fb93..d0f92056df8d224b9b984b27431537717be4c173 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -701,13 +701,13 @@ void WebLocalFrameImpl::setIsolatedWorldHumanReadableName(
void WebLocalFrameImpl::addMessageToConsole(const WebConsoleMessage& message) {
DCHECK(frame());
- MessageLevel webCoreMessageLevel = LogMessageLevel;
+ MessageLevel webCoreMessageLevel = InfoMessageLevel;
switch (message.level) {
- case WebConsoleMessage::LevelDebug:
- webCoreMessageLevel = DebugMessageLevel;
+ case WebConsoleMessage::LevelVerbose:
+ webCoreMessageLevel = VerboseMessageLevel;
break;
- case WebConsoleMessage::LevelLog:
- webCoreMessageLevel = LogMessageLevel;
+ case WebConsoleMessage::LevelInfo:
+ webCoreMessageLevel = InfoMessageLevel;
break;
case WebConsoleMessage::LevelWarning:
webCoreMessageLevel = WarningMessageLevel;
@@ -715,9 +715,6 @@ void WebLocalFrameImpl::addMessageToConsole(const WebConsoleMessage& message) {
case WebConsoleMessage::LevelError:
webCoreMessageLevel = ErrorMessageLevel;
break;
- // Unsupported values.
- case WebConsoleMessage::LevelInfo:
- break;
}
frame()->document()->addConsoleMessage(ConsoleMessage::create(
« no previous file with comments | « third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp ('k') | third_party/WebKit/public/web/ConsoleMessageStructTraits.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698