Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2646033003: DevTools: streamline console logging levels, migrate 'log' to 'info' level, 'debug' to 'verbose' le… (Closed)
Patch Set: same with front-end fixes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index 3834d5ecc739c61f5c4f435d517a7305d3f5833b..8c62058d640b367a3f0953535898d39f52fb1c71 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -922,13 +922,12 @@ Console.ConsoleViewMessage = class {
this._element.message = this;
switch (this._message.level) {
- case SDK.ConsoleMessage.MessageLevel.Log:
- this._element.classList.add('console-log-level');
+ case SDK.ConsoleMessage.MessageLevel.Verbose:
+ this._element.classList.add('console-verbose-level');
this._updateMessageLevelIcon('');
break;
- case SDK.ConsoleMessage.MessageLevel.Debug:
- this._element.classList.add('console-debug-level');
- this._updateMessageLevelIcon('');
+ case SDK.ConsoleMessage.MessageLevel.Info:
+ this._element.classList.add('console-info-level');
break;
case SDK.ConsoleMessage.MessageLevel.Warning:
this._element.classList.add('console-warning-level');
@@ -938,10 +937,6 @@ Console.ConsoleViewMessage = class {
this._element.classList.add('console-error-level');
this._updateMessageLevelIcon('smallicon-error');
break;
- case SDK.ConsoleMessage.MessageLevel.Info:
- this._element.classList.add('console-info-level');
- this._updateMessageLevelIcon('smallicon-info');
- break;
}
this._element.appendChild(this.contentElement());
@@ -997,8 +992,8 @@ Console.ConsoleViewMessage = class {
case SDK.ConsoleMessage.MessageLevel.Error:
this._repeatCountElement.type = 'error';
break;
- case SDK.ConsoleMessage.MessageLevel.Debug:
- this._repeatCountElement.type = 'debug';
+ case SDK.ConsoleMessage.MessageLevel.Verbose:
+ this._repeatCountElement.type = 'verbose';
dgozman 2017/01/20 17:26:33 This requires a change in smallBubble.css.
break;
default:
this._repeatCountElement.type = 'info';

Powered by Google App Engine
This is Rietveld 408576698