Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: content/common/service_manager/service_manager_connection_impl.cc

Issue 2646033002: mash: Exit the root process if the window manager service crashes (Closed)
Patch Set: review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/mash/mash_runner.cc ('k') | services/service_manager/background/background_service_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/service_manager/service_manager_connection_impl.cc
diff --git a/content/common/service_manager/service_manager_connection_impl.cc b/content/common/service_manager/service_manager_connection_impl.cc
index 3e0008cbc9a6fac28a11ce2940547144152c45d6..4e511907808a5d42b03a251d4fc8bc4c876a9aeb 100644
--- a/content/common/service_manager/service_manager_connection_impl.cc
+++ b/content/common/service_manager/service_manager_connection_impl.cc
@@ -213,6 +213,9 @@ class ServiceManagerConnectionImpl::IOThreadContext
void RemoveConnectionFilterOnIOThread(int filter_id) {
base::AutoLock lock(lock_);
auto it = connection_filters_.find(filter_id);
+ // TODO(crbug.com/687247): This DCHECK is hit when the browser is shut down
+ // by the service manager (e.g. in response to an ash crash under mash).
+ // Figure out why.
DCHECK(it != connection_filters_.end());
connection_filters_.erase(it);
}
« no previous file with comments | « chrome/app/mash/mash_runner.cc ('k') | services/service_manager/background/background_service_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698