Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Side by Side Diff: third_party/WebKit/Source/wtf/WTFThreadData.cpp

Issue 2646003003: Avoid checking for WTFThreadData::staticData in wtfThreadData() (Closed)
Patch Set: Simplify :/ Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/wtf/WTFThreadData.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2010 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2010 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 23 matching lines...) Expand all
34 34
35 ThreadSpecific<WTFThreadData>* WTFThreadData::staticData; 35 ThreadSpecific<WTFThreadData>* WTFThreadData::staticData;
36 36
37 WTFThreadData::WTFThreadData() 37 WTFThreadData::WTFThreadData()
38 : m_atomicStringTable(new AtomicStringTable), 38 : m_atomicStringTable(new AtomicStringTable),
39 m_cachedConverterICU(new ICUConverterWrapper), 39 m_cachedConverterICU(new ICUConverterWrapper),
40 m_threadId(internal::currentThreadSyscall()) {} 40 m_threadId(internal::currentThreadSyscall()) {}
41 41
42 WTFThreadData::~WTFThreadData() {} 42 WTFThreadData::~WTFThreadData() {}
43 43
44 void WTFThreadData::initialize() {
45 // WTFThreadData is used on main thread before it could possibly be used
esprehn 2017/02/02 23:24:51 You can remove this comment now. It's per thread a
Charlie Harrison 2017/02/02 23:35:38 Done.
46 // on secondary ones, so there is no need for synchronization here.
47 DCHECK(!WTFThreadData::staticData);
48 WTFThreadData::staticData = new ThreadSpecific<WTFThreadData>;
49 wtfThreadData();
50 }
51
44 #if OS(WIN) && COMPILER(MSVC) 52 #if OS(WIN) && COMPILER(MSVC)
45 size_t WTFThreadData::threadStackSize() { 53 size_t WTFThreadData::threadStackSize() {
46 // Needed to bootstrap WTFThreadData on Windows, because this value is needed 54 // Needed to bootstrap WTFThreadData on Windows, because this value is needed
47 // before the main thread data is fully initialized. 55 // before the main thread data is fully initialized.
48 if (!WTFThreadData::staticData->isSet()) 56 if (!WTFThreadData::staticData->isSet())
49 return internal::threadStackSize(); 57 return internal::threadStackSize();
50 58
51 WTFThreadData& data = wtfThreadData(); 59 WTFThreadData& data = wtfThreadData();
52 if (!data.m_threadStackSize) 60 if (!data.m_threadStackSize)
53 data.m_threadStackSize = internal::threadStackSize(); 61 data.m_threadStackSize = internal::threadStackSize();
54 return data.m_threadStackSize; 62 return data.m_threadStackSize;
55 } 63 }
56 #endif 64 #endif
57 65
58 } // namespace WTF 66 } // namespace WTF
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/wtf/WTFThreadData.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698