ios/clean/chrome/browser/ui/tab/tab_coordinator.mm - Issue 2645973005: Coordinators: let the presenting view controller dismiss.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/clean/chrome/browser/ui/tab/tab_coordinator.mm

Issue 2645973005: Coordinators: let the presenting view controller dismiss. (Closed)

Patch Set: Rebased Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/clean/chrome/browser/ui/tab/tab_coordinator.mm

diff --git a/ios/clean/chrome/browser/ui/tab/tab_coordinator.mm b/ios/clean/chrome/browser/ui/tab/tab_coordinator.mm

index 45ce3877231a0233397de0b4fbfffe274353c5e1..a3221907c7de3f68682463a3044bae2a5ec474ef 100644

--- a/ios/clean/chrome/browser/ui/tab/tab_coordinator.mm

+++ b/ios/clean/chrome/browser/ui/tab/tab_coordinator.mm

@@ -76,8 +76,9 @@ const BOOL kUseBottomToolbar = NO;

}

- (void)stop {

- [self.viewController dismissViewControllerAnimated:self.context.animated

- completion:nil];

+ [self.viewController.presentingViewController

+ dismissViewControllerAnimated:self.context.animated

+ completion:nil];

_webStateObserver.reset();

}