Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2645973003: dart2js: Move lowering of identical(a, b) from builder to optimizer (Closed)

Created:
3 years, 11 months ago by sra1
Modified:
3 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Move lowering of identical(a, b) from builder to optimizer R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/9a2636f99f47f9c90bfdb4c5cee8c3836bd7bd9f

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +3 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 1 chunk +7 lines, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/core_patch.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
3 years, 11 months ago (2017-01-19 23:40:02 UTC) #2
Emily Fortuna
lgtm
3 years, 11 months ago (2017-01-20 00:01:00 UTC) #3
sra1
3 years, 11 months ago (2017-01-20 01:30:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9a2636f99f47f9c90bfdb4c5cee8c3836bd7bd9f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698