Issue 2645973002: Revert "Implemented basic heap memory allocation tracking in MallocHooks using hooks registered wit…

Issue 2645973002: Revert "Implemented basic heap memory allocation tracking in MallocHooks using hooks registered wit… (Closed)

Created:
3 years, 11 months ago by bkonyi

Modified:
3 years, 11 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Implemented basic heap memory allocation tracking in MallocHooks using hooks registered with tcmalloc. Also updated BUILD.gn files to account for include paths within the tcmalloc project." This reverts commit bcd7ba105645d24813333c4ca5bb55b202a6a563. TBR=zra@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/10686766cddb600319820aa31aff42ef82118aee

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -499 lines)			Patch
M	runtime/BUILD.gn	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	runtime/bin/BUILD.gn	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	runtime/bin/gen_snapshot.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/dart.cc	View	3 chunks	+1 line, -3 lines	0 comments	Download
M	runtime/vm/hash_map.h	View	2 chunks	+0 lines, -57 lines	0 comments	Download
M	runtime/vm/hash_map_test.cc	View	2 chunks	+0 lines, -61 lines	0 comments	Download
M	runtime/vm/malloc_hooks.h	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	runtime/vm/malloc_hooks.cc	View	1 chunk	+4 lines, -251 lines	0 comments	Download
D	runtime/vm/malloc_hooks_test.cc	View	1 chunk	+0 lines, -80 lines	0 comments	Download
M	runtime/vm/malloc_hooks_unsupported.cc	View	1 chunk	+3 lines, -25 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 3 (1 generated)

bkonyi

Committed patchset #1 (id:1) manually as 10686766cddb600319820aa31aff42ef82118aee (presubmit successful).

3 years, 11 months ago (2017-01-19 20:14:28 UTC) #2

Message was sent while issue was closed.

lgtm