Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: media/test/pipeline_integration_test.cc

Issue 2645953004: Update duration when demuxed packets exceed known duration. (Closed)
Patch Set: Remux and encode test.ogv. Fixes bad duration. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/test/pipeline_integration_test.cc
diff --git a/media/test/pipeline_integration_test.cc b/media/test/pipeline_integration_test.cc
index b2599ee2c765016b2afe76401d6ac0e42a262e64..7668d28f61cf43e87ce28eb80bf66b43f3ea4b59 100644
--- a/media/test/pipeline_integration_test.cc
+++ b/media/test/pipeline_integration_test.cc
@@ -833,7 +833,8 @@ class BasicMSEPlaybackTest
TEST_P(BasicPlaybackTest, PlayToEnd) {
PlaybackTestData data = GetParam();
- ASSERT_EQ(PIPELINE_OK, Start(data.filename, kClockless));
+ ASSERT_EQ(PIPELINE_OK,
+ Start(data.filename, kClockless | kUnreliableDuration));
EXPECT_EQ(data.start_time_ms, demuxer_->GetStartTime().InMilliseconds());
EXPECT_EQ(data.duration_ms, pipeline_->GetMediaDuration().InMilliseconds());
@@ -874,7 +875,7 @@ const PlaybackTestData kADTSTests[] = {
};
// TODO(chcunningham): Migrate other basic playback tests to TEST_P.
-INSTANTIATE_TEST_CASE_P(PropritaryCodecs,
+INSTANTIATE_TEST_CASE_P(ProprietaryCodecs,
BasicPlaybackTest,
testing::ValuesIn(kADTSTests));
@@ -2545,7 +2546,7 @@ TEST_F(PipelineIntegrationTest, BasicPlayback_MediaSource_Opus441kHz) {
// Ensures audio-only playback with missing or negative timestamps works. Tests
// the common live-streaming case for chained ogg. See http://crbug.com/396864.
TEST_F(PipelineIntegrationTest, BasicPlaybackChainedOgg) {
- ASSERT_EQ(PIPELINE_OK, Start("double-sfx.ogg"));
+ ASSERT_EQ(PIPELINE_OK, Start("double-sfx.ogg", kUnreliableDuration));
Play();
ASSERT_TRUE(WaitUntilOnEnded());
ASSERT_EQ(base::TimeDelta(), demuxer_->GetStartTime());
@@ -2554,7 +2555,7 @@ TEST_F(PipelineIntegrationTest, BasicPlaybackChainedOgg) {
// Ensures audio-video playback with missing or negative timestamps fails softly
// instead of crashing. See http://crbug.com/396864.
TEST_F(PipelineIntegrationTest, BasicPlaybackChainedOggVideo) {
- ASSERT_EQ(PIPELINE_OK, Start("double-bear.ogv"));
+ ASSERT_EQ(PIPELINE_OK, Start("double-bear.ogv", kUnreliableDuration));
Play();
EXPECT_EQ(PIPELINE_ERROR_DECODE, WaitUntilEndedOrError());
ASSERT_EQ(base::TimeDelta(), demuxer_->GetStartTime());

Powered by Google App Engine
This is Rietveld 408576698