Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2423)

Unified Diff: content/renderer/media/render_media_log_unittest.cc

Issue 2645953004: Update duration when demuxed packets exceed known duration. (Closed)
Patch Set: Remove broken CGI server. Rate limit duration changed events. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/render_media_log_unittest.cc
diff --git a/content/renderer/media/render_media_log_unittest.cc b/content/renderer/media/render_media_log_unittest.cc
index c383dcd86a16a35c0540bc3b1c0ee9d6decbf79a..60d3139a1802e7ee2cb92edc595ac0d5554f37a1 100644
--- a/content/renderer/media/render_media_log_unittest.cc
+++ b/content/renderer/media/render_media_log_unittest.cc
@@ -123,4 +123,27 @@ TEST_F(RenderMediaLogTest, BufferedExtents) {
EXPECT_EQ(media::MediaLogEvent::BUFFERED_EXTENTS_CHANGED, events[2].type);
}
+TEST_F(RenderMediaLogTest, DurationChanged) {
+ AddEvent(media::MediaLogEvent::LOAD);
+ AddEvent(media::MediaLogEvent::SEEK);
+
+ // This event is handled separately and should always appear last regardless
+ // of how many times we see it.
+ AddEvent(media::MediaLogEvent::DURATION_SET);
+ AddEvent(media::MediaLogEvent::DURATION_SET);
+ AddEvent(media::MediaLogEvent::DURATION_SET);
+
+ EXPECT_EQ(0, message_count());
+ Advance(base::TimeDelta::FromMilliseconds(1000));
+ EXPECT_EQ(1, message_count());
+
+ // Verify contents. There should only be a single buffered extents changed
+ // event.
+ std::vector<media::MediaLogEvent> events = GetMediaLogEvents();
+ ASSERT_EQ(3u, events.size());
+ EXPECT_EQ(media::MediaLogEvent::LOAD, events[0].type);
+ EXPECT_EQ(media::MediaLogEvent::SEEK, events[1].type);
+ EXPECT_EQ(media::MediaLogEvent::DURATION_SET, events[2].type);
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698