Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: Makefile

Issue 264593002: ARM: update defaults for flags (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: review fix Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/standalone.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Makefile
diff --git a/Makefile b/Makefile
index a99b09c070504680ab1634aa771cb78ddd4e3383..caa9f089145e16b2052491ff48766cc184e80681 100644
--- a/Makefile
+++ b/Makefile
@@ -156,11 +156,6 @@ ifeq ($(armv7), true)
endif
endif
endif
-# vfp2=off. Deprecated, use armfpu=
-# vfp3=off. Deprecated, use armfpu=
-ifeq ($(vfp3), off)
- GYPFLAGS += -Darm_fpu=vfp
-endif
# hardfp=on/off. Deprecated, use armfloatabi
ifeq ($(hardfp),on)
GYPFLAGS += -Darm_float_abi=hard
@@ -169,16 +164,10 @@ ifeq ($(hardfp),off)
GYPFLAGS += -Darm_float_abi=softfp
endif
endif
-# armneon=on/off
-ifeq ($(armneon), on)
- GYPFLAGS += -Darm_neon=1
-endif
# fpu: armfpu=xxx
# xxx: vfp, vfpv3-d16, vfpv3, neon.
ifeq ($(armfpu),)
-ifneq ($(vfp3), off)
GYPFLAGS += -Darm_fpu=default
-endif
else
GYPFLAGS += -Darm_fpu=$(armfpu)
endif
@@ -201,7 +190,7 @@ endif
# armtest=on
# With this flag set, by default v8 will only use features implied
# by the compiler (no probe). This is done by modifying the default
-# values of enable_armv7, enable_vfp2, enable_vfp3 and enable_32dregs.
+# values of enable_armv7, enable_vfp3, enable_32dregs and enable_neon.
# Modifying these flags when launching v8 will enable the probing for
# the specified values.
# When using the simulator, this flag is implied.
« no previous file with comments | « no previous file | build/standalone.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698