Issue 264593002: ARM: update defaults for flags - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(196)

My Issues | Starred Open | Closed | All

Issue 264593002: ARM: update defaults for flags (Closed)

Created:
6 years, 7 months ago by vincent.belliard

Modified:
6 years, 7 months ago

Reviewers:
Benedikt Meurer, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ARM: update defaults for flags R=ulan@chromium.org, bmeurer@chromium.org BUG=

Patch Set 1 #

Total comments: 4

Patch Set 2 : review fix #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -57 lines)			Patch
	M	Makefile	View	1	3 chunks	+1 line, -12 lines	0 comments	Download
	M	build/standalone.gypi	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
	M	build/toolchain.gypi	View	1	6 chunks	+30 lines, -20 lines	0 comments	Download
	M	src/arm/assembler-arm.cc	View	1	2 chunks	+21 lines, -23 lines	0 comments	Download
	M	src/flag-definitions.h	View	1	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vincent.belliard

Update probing for simulator to be consistent with the makefile. Examples: Native (a15): make arm.release ...

6 years, 7 months ago (2014-04-30 08:42:36 UTC) #1

Update probing for simulator to be consistent with the makefile.

Examples:

Native (a15):
make arm.release
Snapshot: ARMv7=1 VFP3=1 VFP32DREGS=0 NEON=0 SUDIV=0 UNALIGNED_ACCESSES=1
MOVW_MOVT_IMMEDIATE_LOADS=0 USE_EABI_HARDFLOAT=1
d8:       ARMv7=1 VFP3=1 VFP32DREGS=1 NEON=1 SUDIV=1 UNALIGNED_ACCESSES=1
MOVW_MOVT_IMMEDIATE_LOADS=0 USE_EABI_HARDFLOAT=1

make arm.release armfpu=neon
Snapshot: ARMv7=1 VFP3=1 VFP32DREGS=0 NEON=0 SUDIV=0 UNALIGNED_ACCESSES=1
MOVW_MOVT_IMMEDIATE_LOADS=0 USE_EABI_HARDFLOAT=1
d8:       ARMv7=1 VFP3=1 VFP32DREGS=1 NEON=1 SUDIV=1 UNALIGNED_ACCESSES=1
MOVW_MOVT_IMMEDIATE_LOADS=0 USE_EABI_HARDFLOAT=1

make arm.release armfpu=neon armtest=on
Snapshot: ARMv7=1 VFP3=1 VFP32DREGS=1 NEON=1 SUDIV=0 UNALIGNED_ACCESSES=1
MOVW_MOVT_IMMEDIATE_LOADS=0 USE_EABI_HARDFLOAT=1
d8:       ARMv7=1 VFP3=1 VFP32DREGS=1 NEON=1 SUDIV=1 UNALIGNED_ACCESSES=1
MOVW_MOVT_IMMEDIATE_LOADS=0 USE_EABI_HARDFLOAT=1

make arm.release armfpu=vfpv3-d16 armtest=on
Snapshot: ARMv7=1 VFP3=1 VFP32DREGS=0 NEON=0 SUDIV=0 UNALIGNED_ACCESSES=1
MOVW_MOVT_IMMEDIATE_LOADS=0 USE_EABI_HARDFLOAT=1
d8:       ARMv7=1 VFP3=1 VFP32DREGS=0 NEON=0 SUDIV=1 UNALIGNED_ACCESSES=1
MOVW_MOVT_IMMEDIATE_LOADS=0 USE_EABI_HARDFLOAT=1

Simulation (xeon):
make arm.release
Snapshot: ARMv7=1 VFP3=1 VFP32DREGS=0 NEON=0 SUDIV=0 UNALIGNED_ACCESSES=1
MOVW_MOVT_IMMEDIATE_LOADS=0 USE_EABI_HARDFLOAT=0
d8:       ARMv7=1 VFP3=1 VFP32DREGS=1 NEON=1 SUDIV=1 UNALIGNED_ACCESSES=1
MOVW_MOVT_IMMEDIATE_LOADS=0 USE_EABI_HARDFLOAT=0

make arm.release armfpu=neon
Snapshot: ARMv7=1 VFP3=1 VFP32DREGS=1 NEON=1 SUDIV=0 UNALIGNED_ACCESSES=1
MOVW_MOVT_IMMEDIATE_LOADS=0 USE_EABI_HARDFLOAT=0
d8:       ARMv7=1 VFP3=1 VFP32DREGS=1 NEON=1 SUDIV=1 UNALIGNED_ACCESSES=1
MOVW_MOVT_IMMEDIATE_LOADS=0 USE_EABI_HARDFLOAT=0

make arm.release armfpu=vfpv3-d16
Snapshot: ARMv7=1 VFP3=1 VFP32DREGS=0 NEON=0 SUDIV=0 UNALIGNED_ACCESSES=1
MOVW_MOVT_IMMEDIATE_LOADS=0 USE_EABI_HARDFLOAT=0
d8:       ARMv7=1 VFP3=1 VFP32DREGS=0 NEON=0 SUDIV=1 UNALIGNED_ACCESSES=1
MOVW_MOVT_IMMEDIATE_LOADS=0 USE_EABI_HARDFLOAT=0

Benedikt Meurer

LGTM with comment. https://codereview.chromium.org/264593002/diff/1/Makefile File Makefile (right): https://codereview.chromium.org/264593002/diff/1/Makefile#newcode172 Makefile:172: # armneon=on/off. Deprecated, use armfpu= I'd ...

6 years, 7 months ago (2014-05-02 06:51:52 UTC) #2

vincent.belliard

6 years, 7 months ago (2014-05-06 13:01:48 UTC) #3

https://codereview.chromium.org/264593002/diff/1/Makefile
File Makefile (right):

https://codereview.chromium.org/264593002/diff/1/Makefile#newcode172
Makefile:172: # armneon=on/off. Deprecated, use armfpu=
On 2014/05/02 06:51:52, Benedikt Meurer wrote:
> I'd rather remove it completely...

Done.

https://codereview.chromium.org/264593002/diff/1/build/toolchain.gypi
File build/toolchain.gypi (right):

https://codereview.chromium.org/264593002/diff/1/build/toolchain.gypi#newcode156
build/toolchain.gypi:156: [ 'arm_fpu=="neon" or arm_neon==1', {
On 2014/05/02 06:51:52, Benedikt Meurer wrote:
> ...and also remove it from the gypi file.

Done.

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698