Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1222)

Unified Diff: extensions/browser/api/management/management_api.cc

Issue 2645863004: Simplify managing visibility of extensions in settings. (Closed)
Patch Set: Fixed logic so tests pass. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/management/management_api.cc
diff --git a/extensions/browser/api/management/management_api.cc b/extensions/browser/api/management/management_api.cc
index 18f94189620adb1a0bb58b74cdd42ef885bf74a8..0cf0c2450492964d06fa3a8b86e1288acb28aa42 100644
--- a/extensions/browser/api/management/management_api.cc
+++ b/extensions/browser/api/management/management_api.cc
@@ -257,8 +257,8 @@ void AddExtensionInfo(const ExtensionSet& extensions,
iter != extensions.end(); ++iter) {
const Extension& extension = **iter;
- if (extension.ShouldNotBeVisible())
- continue; // Skip built-in extensions/apps.
+ if (!extension.ShouldExposeViaManagementAPI())
+ continue;
extension_list->push_back(CreateExtensionInfo(extension, context));
}
@@ -416,7 +416,7 @@ ExtensionFunction::ResponseAction ManagementSetEnabledFunction::Run() {
const Extension* extension =
registry->GetExtensionById(extension_id_, ExtensionRegistry::EVERYTHING);
- if (!extension || extension->ShouldNotBeVisible())
+ if (!extension || !extension->ShouldExposeViaManagementAPI())
return RespondNow(Error(keys::kNoExtensionError, extension_id_));
bool enabled = params->enabled;
@@ -507,7 +507,7 @@ ExtensionFunction::ResponseAction ManagementUninstallFunctionBase::Uninstall(
extensions::ExtensionRegistry::Get(browser_context())
->GetExtensionById(target_extension_id_,
ExtensionRegistry::EVERYTHING);
- if (!target_extension || target_extension->ShouldNotBeVisible()) {
+ if (!target_extension || !target_extension->ShouldExposeViaManagementAPI()) {
return RespondNow(Error(keys::kNoExtensionError, target_extension_id_));
}
@@ -844,8 +844,8 @@ void ManagementEventRouter::BroadcastEvent(
const Extension* extension,
events::HistogramValue histogram_value,
const char* event_name) {
- if (extension->ShouldNotBeVisible())
- return; // Don't dispatch events for built-in extenions.
+ if (!extension->ShouldExposeViaManagementAPI())
+ return;
std::unique_ptr<base::ListValue> args(new base::ListValue());
if (event_name == management::OnUninstalled::kEventName) {
args->AppendString(extension->id());

Powered by Google App Engine
This is Rietveld 408576698