Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: extensions/common/extension.h

Issue 2645863004: Simplify managing visibility of extensions in settings. (Closed)
Patch Set: Fixed logic so tests pass. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_EXTENSION_H_ 5 #ifndef EXTENSIONS_COMMON_EXTENSION_H_
6 #define EXTENSIONS_COMMON_EXTENSION_H_ 6 #define EXTENSIONS_COMMON_EXTENSION_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <set> 10 #include <set>
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 // Returns true if the extension should be displayed in the app launcher. 246 // Returns true if the extension should be displayed in the app launcher.
247 bool ShouldDisplayInAppLauncher() const; 247 bool ShouldDisplayInAppLauncher() const;
248 248
249 // Returns true if the extension should be displayed in the browser NTP. 249 // Returns true if the extension should be displayed in the browser NTP.
250 bool ShouldDisplayInNewTabPage() const; 250 bool ShouldDisplayInNewTabPage() const;
251 251
252 // Returns true if the extension should be displayed in the extension 252 // Returns true if the extension should be displayed in the extension
253 // settings page (i.e. chrome://extensions). 253 // settings page (i.e. chrome://extensions).
254 bool ShouldDisplayInExtensionSettings() const; 254 bool ShouldDisplayInExtensionSettings() const;
255 255
256 // Returns true if the extension should not be shown anywhere. This is 256 // Returns true if the extension should be exposed via the chrome.management
257 // mostly the same as the extension being a component extension, but also 257 // API.
258 // includes non-component apps that are hidden from the app launcher and ntp. 258 bool ShouldExposeViaManagementAPI() const;
259 bool ShouldNotBeVisible() const;
260 259
261 // Get the manifest data associated with the key, or NULL if there is none. 260 // Get the manifest data associated with the key, or NULL if there is none.
262 // Can only be called after InitValue is finished. 261 // Can only be called after InitValue is finished.
263 ManifestData* GetManifestData(const std::string& key) const; 262 ManifestData* GetManifestData(const std::string& key) const;
264 263
265 // Sets |data| to be associated with the key. Takes ownership of |data|. 264 // Sets |data| to be associated with the key. Takes ownership of |data|.
266 // Can only be called before InitValue is finished. Not thread-safe; 265 // Can only be called before InitValue is finished. Not thread-safe;
267 // all SetManifestData calls should be on only one thread. 266 // all SetManifestData calls should be on only one thread.
268 void SetManifestData(const std::string& key, ManifestData* data); 267 void SetManifestData(const std::string& key, ManifestData* data);
269 268
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after
558 const PermissionSet& permissions; 557 const PermissionSet& permissions;
559 558
560 UpdatedExtensionPermissionsInfo(const Extension* extension, 559 UpdatedExtensionPermissionsInfo(const Extension* extension,
561 const PermissionSet& permissions, 560 const PermissionSet& permissions,
562 Reason reason); 561 Reason reason);
563 }; 562 };
564 563
565 } // namespace extensions 564 } // namespace extensions
566 565
567 #endif // EXTENSIONS_COMMON_EXTENSION_H_ 566 #endif // EXTENSIONS_COMMON_EXTENSION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698