Simplify managing visibility of extensions in settings.

extensions/common/extension.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/extension.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <utility>
@@ skipping 339 matching lines @@
 bool Extension::ShouldDisplayInNewTabPage() const {
   // Only apps should be displayed on the NTP.
   return is_app() && display_in_new_tab_page_;
 }
 
 bool Extension::ShouldDisplayInExtensionSettings() const {
   // Don't show for themes since the settings UI isn't really useful for them.
   if (is_theme())
     return false;
 
-  // Don't show component extensions and invisible apps.
-  if (ShouldNotBeVisible())
+  // Hide component extensions because they are only extensions as an
+  // implementation detail of Chrome.
+  if (extensions::Manifest::IsComponentLocation(location()) &&
+      !base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kShowComponentExtensionOptions)) {
     return false;
-
-  // Always show unpacked extensions and apps.
-  if (Manifest::IsUnpackedLocation(location()))
-    return true;
+  }
 
   // Unless they are unpacked, never show hosted apps. Note: We intentionally
   // show packaged apps and platform apps because there are some pieces of
   // functionality that are only available in chrome://extensions/ but which
   // are needed for packaged and platform apps. For example, inspecting
   // background pages. See http://crbug.com/116134.
-  if (is_hosted_app())
+  if (!Manifest::IsUnpackedLocation(location()) && is_hosted_app())
     return false;
 
   return true;
 }
 
-bool Extension::ShouldNotBeVisible() const {
-  // Don't show component extensions because they are only extensions as an
+bool Extension::ShouldExposeViaManagementAPI() const {
+  // Hide component extensions because they are only extensions as an
   // implementation detail of Chrome.
-  if (extensions::Manifest::IsComponentLocation(location()) &&
-      !base::CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kShowComponentExtensionOptions)) {
-    return true;
-  }
-
-  // Always show unpacked extensions and apps.
-  if (Manifest::IsUnpackedLocation(location()))
-    return false;
-
-  // Don't show apps that aren't visible in either launcher or ntp.
-  if (is_app() && !ShouldDisplayInAppLauncher() && !ShouldDisplayInNewTabPage())

[lazyboy, 2017/01/23 22:22:26]

2) Apps that didn't specify to show themselves in launcher/NTP: a) management
API would have not see them before, but now they do. b) same for
chrome://settings

[mtomasz, 2017/01/26 08:38:30]

Correct. I believe this was a bug. Hiding from launcher doesn't mean that the
item should be hidden from management API or from chrome://extensions. These
things are completely separate.

-    return true;
-
-  return false;
+  return !extensions::Manifest::IsComponentLocation(location());

[lazyboy, 2017/01/23 22:22:26]

1) So management api won't see component extensions anymore even if one has
passed --show-component.. flag, right? I'd highlight that fact in the CL
description, possibly at the very beginning after the subject line.

[mtomasz, 2017/01/26 08:38:30]

Correct. --show-component-extensions-options refers to chrome://extensions so no
reason to affect the management API. Added explanation in the CL description.

 }
 
 Extension::ManifestData* Extension::GetManifestData(const std::string& key)
     const {
   DCHECK(finished_parsing_manifest_ || thread_checker_.CalledOnValidThread());
   ManifestDataMap::const_iterator iter = manifest_data_.find(key);
   if (iter != manifest_data_.end())
     return iter->second.get();
   return NULL;
 }
@@ skipping 394 matching lines @@
     : reason(reason),
       extension(extension) {}
 
 UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo(
     const Extension* extension,
     const PermissionSet& permissions,
     Reason reason)
     : reason(reason), extension(extension), permissions(permissions) {}
 
 }   // namespace extensions