Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1776)

Issue 264583007: flatten resources directory (Closed)

Created:
6 years, 7 months ago by hal.canary
Modified:
6 years, 7 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Flatten resources directory On android trybots, the files in a subdirectory weren't being loaded onto the device. Consequently, the ImageDecoderOptions test was not testing anything. I had to relax that unit test to reflect the existing behavior of our libjpeg decoder on Android. R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=14682

Patch Set 1 : AnotherPatchSet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
D resources/encoding/randPixels.bmp View Binary file 0 comments Download
D resources/encoding/randPixels.gif View Binary file 0 comments Download
D resources/encoding/randPixels.jpg View Binary file 0 comments Download
D resources/encoding/randPixels.png View Binary file 0 comments Download
D resources/encoding/randPixels.webp View Binary file 0 comments Download
A + resources/randPixels.bmp View Binary file 0 comments Download
A + resources/randPixels.gif View Binary file 0 comments Download
A + resources/randPixels.jpg View Binary file 0 comments Download
A + resources/randPixels.png View Binary file 0 comments Download
A + resources/randPixels.webp View Binary file 0 comments Download
M tests/ImageDecodingTest.cpp View 5 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hal.canary
6 years, 7 months ago (2014-05-02 13:20:10 UTC) #1
djsollen
lgtm
6 years, 7 months ago (2014-05-09 16:01:44 UTC) #2
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 7 months ago (2014-05-09 16:16:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/264583007/20001
6 years, 7 months ago (2014-05-09 16:17:51 UTC) #4
commit-bot: I haz the power
Change committed as 14678
6 years, 7 months ago (2014-05-09 16:24:15 UTC) #5
hal.canary
6 years, 7 months ago (2014-05-09 18:08:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r14682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698