Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: third_party/WebKit/Source/core/frame/PlatformEventController.cpp

Issue 2645823002: Change PlatformEventController to take LocalFrame rather than Page. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/PlatformEventController.cpp
diff --git a/third_party/WebKit/Source/core/frame/PlatformEventController.cpp b/third_party/WebKit/Source/core/frame/PlatformEventController.cpp
index 032c8e9d38c93c3c68069f39d4a1f01d74a52957..bf523742e73ad2416036c76340f953bd85244941 100644
--- a/third_party/WebKit/Source/core/frame/PlatformEventController.cpp
+++ b/third_party/WebKit/Source/core/frame/PlatformEventController.cpp
@@ -8,8 +8,8 @@
namespace blink {
-PlatformEventController::PlatformEventController(Page* page)
- : PageVisibilityObserver(page),
+PlatformEventController::PlatformEventController(LocalFrame* frame)
dcheng 2017/01/20 07:18:17 Nit: I think this can be passed as mutable ref. Bl
joelhockey 2017/02/01 07:17:29 Daniel, I must confess I don't know a lot of C++.
+ : PageVisibilityObserver(frame->page()),
m_hasEventListener(false),
m_isActive(false),
m_timer(this, &PlatformEventController::oneShotCallback) {}

Powered by Google App Engine
This is Rietveld 408576698