components/payments/content/android/payment_manifest_parser.mojom - Issue 2645813006: Download web payment manifests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/payments/content/android/payment_manifest_parser.mojom

Issue 2645813006: Download web payment manifests. (Closed)

Patch Set: At most INT_MAX sections in manifest and fingperints in section Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [JavaPackage="org.chromium.payments.mojom"]

	6 module payments.mojom;

	7

	8 struct PaymentManifestSection {

	9 string package_name;

	10 // Optional version number. 0 if not defined.

	11 int64 version;

	12 array<string> sha256_cert_fingerprints;
	palmer 2017/03/03 22:56:31 Is it possible to express a tighter type-fit, e.g. Is it possible to express a tighter type-fit, e.g. array<uint8[64]> sha256_cert_fingerprints; ? Also, for my info, are these fingerprints of the cert, fingerprints from in the cert, or the result of sha256(cert.getPublicKeyBytes()) ? please use gerrit instead 2017/03/09 18:05:33 Tightened the type. Added a comment on what this a Show quoted text On 2017/03/03 22:56:31, palmer wrote: > Is it possible to express a tighter type-fit, e.g. > > array<uint8[64]> sha256_cert_fingerprints; > > ? > > Also, for my info, are these fingerprints of the cert, fingerprints from in the > cert, or the result of sha256(cert.getPublicKeyBytes()) ? Tightened the type. Added a comment on what this actually is.
	13 };

	14

	15 interface PaymentManifestParser {

	16 Parse(string content) => (array<PaymentManifestSection> manifest);

	17 };

OLD	NEW