third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp - Issue 2645813003: [Bindings] Make exported functions visible from other components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp

Issue 2645813003: [Bindings] Make exported functions visible from other components (Closed)

Patch Set: . Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp

index 70cb40114d904d14abba4d1888f7e56a2f1c4201..f83df0c29524840b7e933cf6413e203a7dd72864 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp

@@ -57,12 +57,12 @@ static_assert(

namespace TestConstantsV8Internal {

-void DEPRECATED_CONSTANTConstantGetterCallback(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>& info) {

+CORE_EXPORT void DEPRECATED_CONSTANTConstantGetterCallback(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>& info) {

Deprecation::countDeprecation(currentExecutionContext(info.GetIsolate()), UseCounter::Constant);

v8SetReturnValueInt(info, 1);

}

-void MEASURED_CONSTANTConstantGetterCallback(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>& info) {

+CORE_EXPORT void MEASURED_CONSTANTConstantGetterCallback(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>& info) {

UseCounter::count(currentExecutionContext(info.GetIsolate()), UseCounter::Constant);

v8SetReturnValueInt(info, 1);

}