Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

Issue 2645813003: [Bindings] Make exported functions visible from other components (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
index d32da99b2f0b7cfb2737815fb7cb53e9b36bfe63..16bb616edd9650a10e3230642c7b258e75331c56 100644
--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
@@ -189,7 +189,7 @@ static void (*{{method.name}}MethodForPartialInterface)(const v8::FunctionCallba
{##############################################################################}
{% block security_check_functions %}
{% if has_access_check_callbacks and not is_partial %}
-bool securityCheck(v8::Local<v8::Context> accessingContext, v8::Local<v8::Object> accessedObject, v8::Local<v8::Value> data) {
+{{exported}}bool securityCheck(v8::Local<v8::Context> accessingContext, v8::Local<v8::Object> accessedObject, v8::Local<v8::Value> data) {
{% if interface_name == 'Window' %}
v8::Isolate* isolate = v8::Isolate::GetCurrent();
v8::Local<v8::Object> window = V8Window::findInstanceInPrototypeChain(accessedObject, isolate);
@@ -230,7 +230,7 @@ static const struct {
{% endif %}
{% if has_cross_origin_named_getter %}
-void crossOriginNamedGetter(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info) {
+{{exported}}void crossOriginNamedGetter(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info) {
if (!name->IsString())
return;
const AtomicString& propertyName = toCoreAtomicString(name.As<v8::String>());
@@ -257,7 +257,7 @@ void crossOriginNamedGetter(v8::Local<v8::Name> name, const v8::PropertyCallback
{% endif %}
{% if has_cross_origin_named_setter %}
-void crossOriginNamedSetter(v8::Local<v8::Name> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<v8::Value>& info) {
+{{exported}}void crossOriginNamedSetter(v8::Local<v8::Name> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<v8::Value>& info) {
if (!name->IsString())
return;
const AtomicString& propertyName = toCoreAtomicString(name.As<v8::String>());
@@ -280,7 +280,7 @@ void crossOriginNamedSetter(v8::Local<v8::Name> name, v8::Local<v8::Value> value
{% endif %}
{% if has_cross_origin_named_enumerator %}
-void crossOriginNamedEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info) {
+{{exported}}void crossOriginNamedEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info) {
Vector<String> names;
for (const auto& attribute : kCrossOriginAttributeTable)
names.push_back(attribute.name);
@@ -292,7 +292,7 @@ void crossOriginNamedEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info)
{% endif %}
{% if has_cross_origin_indexed_getter %}
-void crossOriginIndexedGetter(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info) {
+{{exported}}void crossOriginIndexedGetter(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info) {
{% if indexed_property_getter.is_custom %}
{{v8_class}}::indexedPropertyGetterCustom(index, info);
{% else %}

Powered by Google App Engine
This is Rietveld 408576698