Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl

Issue 2645813003: [Bindings] Make exported functions visible from other components (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/templates/constants.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
index a2cfd7a60dbb4eb07c1111af8d47bdb517a4feb4..7550a07909499b173d56cb0f3785aa515d5d03f8 100644
--- a/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
@@ -188,7 +188,7 @@ if ({{cpp_value}}.isEmpty()) {
{##############################################################################}
{% macro attribute_getter_callback(attribute, world_suffix) %}
-void {{attribute.name}}AttributeGetterCallback{{world_suffix}}(
+{{exported}}void {{attribute.name}}AttributeGetterCallback{{world_suffix}}(
{%- if attribute.is_data_type_property %}
v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>& info
{%- else %}
@@ -229,7 +229,7 @@ const v8::FunctionCallbackInfo<v8::Value>& info
{##############################################################################}
{% macro attribute_cache_property_callback(attribute) %}
-v8::Local<v8::Private> {{attribute.name}}CachedAccessorCallback(v8::Isolate* isolate)
+{{exported}}v8::Local<v8::Private> {{attribute.name}}CachedAccessorCallback(v8::Isolate* isolate)
{
return V8PrivateProperty::get{{attribute.cached_accessor_name}}(isolate).getPrivate();
}
@@ -238,7 +238,7 @@ v8::Local<v8::Private> {{attribute.name}}CachedAccessorCallback(v8::Isolate* iso
{##############################################################################}
{% macro constructor_getter_callback(attribute, world_suffix) %}
-void {{attribute.name}}ConstructorGetterCallback{{world_suffix}}(v8::Local<v8::Name> property, const v8::PropertyCallbackInfo<v8::Value>& info) {
+{{exported}}void {{attribute.name}}ConstructorGetterCallback{{world_suffix}}(v8::Local<v8::Name> property, const v8::PropertyCallbackInfo<v8::Value>& info) {
{% if attribute.deprecate_as %}
Deprecation::countDeprecation(currentExecutionContext(info.GetIsolate()), UseCounter::{{attribute.deprecate_as}});
{% endif %}
@@ -366,7 +366,7 @@ v8::Local<v8::Value> v8Value, const v8::FunctionCallbackInfo<v8::Value>& info
{##############################################################################}
{% macro attribute_setter_callback(attribute, world_suffix) %}
-void {{attribute.name}}AttributeSetterCallback{{world_suffix}}(
+{{exported}}void {{attribute.name}}AttributeSetterCallback{{world_suffix}}(
{%- if attribute.is_data_type_property %}
v8::Local<v8::Name>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info
{%- else %}
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/templates/constants.cpp.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698