Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 26458006: [NaClDocs] Fill in the landing page for the SDK section of the docs. (Closed)

Created:
7 years, 2 months ago by jvoung (off chromium)
Modified:
7 years, 2 months ago
Reviewers:
binji, Sam Clegg, eliben
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[NaClDocs] Fill in the landing page for the SDK section of the docs. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3634 NOTRY=true (just docs) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229288

Patch Set 1 #

Patch Set 2 : tweak #

Total comments: 4

Patch Set 3 : nuke Makefiles section #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M native_client_sdk/src/doc/sdk/index.rst View 1 2 1 chunk +44 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
jvoung (off chromium)
7 years, 2 months ago (2013-10-16 21:58:29 UTC) #1
eliben
https://codereview.chromium.org/26458006/diff/3001/native_client_sdk/src/doc/sdk/index.rst File native_client_sdk/src/doc/sdk/index.rst (right): https://codereview.chromium.org/26458006/diff/3001/native_client_sdk/src/doc/sdk/index.rst#newcode16 native_client_sdk/src/doc/sdk/index.rst:16: (e.g., Pepper 28 or Pepper 29). Review the maybe ...
7 years, 2 months ago (2013-10-16 22:05:21 UTC) #2
jvoung (off chromium)
https://codereview.chromium.org/26458006/diff/3001/native_client_sdk/src/doc/sdk/index.rst File native_client_sdk/src/doc/sdk/index.rst (right): https://codereview.chromium.org/26458006/diff/3001/native_client_sdk/src/doc/sdk/index.rst#newcode16 native_client_sdk/src/doc/sdk/index.rst:16: (e.g., Pepper 28 or Pepper 29). Review the On ...
7 years, 2 months ago (2013-10-16 23:56:13 UTC) #3
jvoung (off chromium)
ping
7 years, 2 months ago (2013-10-17 22:46:38 UTC) #4
eliben
lgtm
7 years, 2 months ago (2013-10-17 22:52:16 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-10-18 00:11:15 UTC) #6
binji
lgtm
7 years, 2 months ago (2013-10-18 00:55:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/26458006/8001
7 years, 2 months ago (2013-10-18 01:14:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/26458006/8001
7 years, 2 months ago (2013-10-18 01:24:00 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-18 03:03:09 UTC) #10
Message was sent while issue was closed.
Change committed as 229288

Powered by Google App Engine
This is Rietveld 408576698