Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: src/code-stubs.h

Issue 2645743002: [builtins] Port parameter and argument-related code stubs to CSA (Closed)
Patch Set: Review feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index b5d6b045c38bbb29012495a22c987de3c719f67d..4c9aa1ac3f5d82f27186041758c21194916f01a7 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -49,9 +49,6 @@ class Node;
V(StoreBufferOverflow) \
V(StoreSlowElement) \
V(SubString) \
- V(FastNewRestParameter) \
- V(FastNewSloppyArguments) \
- V(FastNewStrictArguments) \
V(NameDictionaryLookup) \
/* This can be removed once there are no */ \
/* more deopting Hydrogen stubs. */ \
@@ -748,69 +745,6 @@ class NumberToStringStub final : public TurboFanCodeStub {
DEFINE_TURBOFAN_CODE_STUB(NumberToString, TurboFanCodeStub);
};
-// TODO(turbofan): This stub should be possible to write in TurboFan
-// using the CodeStubAssembler very soon in a way that is as efficient
-// and easy as the current handwritten version, which is partly a copy
-// of the strict arguments object materialization code.
-class FastNewRestParameterStub final : public PlatformCodeStub {
- public:
- explicit FastNewRestParameterStub(Isolate* isolate,
- bool skip_stub_frame = false)
- : PlatformCodeStub(isolate) {
- minor_key_ = SkipStubFrameBits::encode(skip_stub_frame);
- }
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(FastNewRestParameter);
- DEFINE_PLATFORM_CODE_STUB(FastNewRestParameter, PlatformCodeStub);
-
- int skip_stub_frame() const { return SkipStubFrameBits::decode(minor_key_); }
-
- private:
- class SkipStubFrameBits : public BitField<bool, 0, 1> {};
-};
-
-
-// TODO(turbofan): This stub should be possible to write in TurboFan
-// using the CodeStubAssembler very soon in a way that is as efficient
-// and easy as the current handwritten version.
-class FastNewSloppyArgumentsStub final : public PlatformCodeStub {
- public:
- explicit FastNewSloppyArgumentsStub(Isolate* isolate,
- bool skip_stub_frame = false)
- : PlatformCodeStub(isolate) {
- minor_key_ = SkipStubFrameBits::encode(skip_stub_frame);
- }
-
- int skip_stub_frame() const { return SkipStubFrameBits::decode(minor_key_); }
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(FastNewSloppyArguments);
- DEFINE_PLATFORM_CODE_STUB(FastNewSloppyArguments, PlatformCodeStub);
-
- private:
- class SkipStubFrameBits : public BitField<bool, 0, 1> {};
-};
-
-
-// TODO(turbofan): This stub should be possible to write in TurboFan
-// using the CodeStubAssembler very soon in a way that is as efficient
-// and easy as the current handwritten version.
-class FastNewStrictArgumentsStub final : public PlatformCodeStub {
- public:
- explicit FastNewStrictArgumentsStub(Isolate* isolate,
- bool skip_stub_frame = false)
- : PlatformCodeStub(isolate) {
- minor_key_ = SkipStubFrameBits::encode(skip_stub_frame);
- }
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(FastNewStrictArguments);
- DEFINE_PLATFORM_CODE_STUB(FastNewStrictArguments, PlatformCodeStub);
-
- int skip_stub_frame() const { return SkipStubFrameBits::decode(minor_key_); }
-
- private:
- class SkipStubFrameBits : public BitField<bool, 0, 1> {};
-};
-
class CreateAllocationSiteStub : public TurboFanCodeStub {
public:
explicit CreateAllocationSiteStub(Isolate* isolate)
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698