Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2645733004: Run tree shaking in strong-mode baseline tests. (Closed)

Created:
3 years, 11 months ago by asgerf
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run tree shaking in strong-mode baseline tests. This test now asserts that the string literal "unused" does not occur in the output in addition to checking the expected output. R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/b07ab608e9dc1f0b31933d15afbf02da4f432a1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -109 lines) Patch
M pkg/kernel/test/baseline_strong_mode_test.dart View 3 chunks +13 lines, -0 lines 0 comments Download
A pkg/kernel/testcases/input/unused_methods.dart View 1 chunk +90 lines, -0 lines 0 comments Download
A pkg/kernel/testcases/spec-mode/unused_methods.baseline.txt View 1 chunk +85 lines, -0 lines 0 comments Download
M pkg/kernel/testcases/strong-mode/DeltaBlue.baseline.txt View 2 chunks +0 lines, -5 lines 0 comments Download
M pkg/kernel/testcases/strong-mode/async_function.baseline.txt View 1 chunk +0 lines, -20 lines 0 comments Download
M pkg/kernel/testcases/strong-mode/escape.baseline.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/kernel/testcases/strong-mode/micro.baseline.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/kernel/testcases/strong-mode/named_parameters.baseline.txt View 1 chunk +2 lines, -10 lines 0 comments Download
M pkg/kernel/testcases/strong-mode/optional.baseline.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/kernel/testcases/strong-mode/prefer_baseclass.baseline.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/kernel/testcases/strong-mode/redirecting_factory.baseline.txt View 1 chunk +4 lines, -15 lines 0 comments Download
M pkg/kernel/testcases/strong-mode/stringliteral.baseline.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/kernel/testcases/strong-mode/uninitialized_fields.baseline.txt View 1 chunk +0 lines, -33 lines 0 comments Download
A pkg/kernel/testcases/strong-mode/unused_methods.baseline.txt View 1 chunk +67 lines, -0 lines 0 comments Download
A pkg/kernel/testcases/type-propagation/unused_methods.baseline.txt View 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
3 years, 11 months ago (2017-01-19 13:39:03 UTC) #2
Kevin Millikin (Google)
lgtm
3 years, 11 months ago (2017-01-19 13:42:10 UTC) #3
asgerf
3 years, 11 months ago (2017-01-23 09:39:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b07ab608e9dc1f0b31933d15afbf02da4f432a1e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698