Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/prerender/prerender_util.cc

Issue 2645713003: [Prerender] Cleanup prerender_util (Closed)
Patch Set: Review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_util.h ('k') | chrome/browser/prerender/prerender_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_util.cc
diff --git a/chrome/browser/prerender/prerender_util.cc b/chrome/browser/prerender/prerender_util.cc
index a9f380b8bd9d9a4d649f6a62042f0e92ea755dd9..b35ad9330c290d3ee2e412f6f496b588c1429c37 100644
--- a/chrome/browser/prerender/prerender_util.cc
+++ b/chrome/browser/prerender/prerender_util.cc
@@ -4,17 +4,9 @@
#include "chrome/browser/prerender/prerender_util.h"
-#include "base/logging.h"
#include "base/metrics/histogram_macros.h"
-#include "base/metrics/sparse_histogram.h"
-#include "base/strings/string_util.h"
-#include "content/public/browser/resource_request_info.h"
-#include "content/public/common/resource_type.h"
-#include "net/http/http_response_headers.h"
-#include "net/url_request/url_request.h"
-#include "url/third_party/mozilla/url_parse.h"
-#include "url/url_canon.h"
-#include "url/url_util.h"
+#include "components/google/core/browser/google_util.h"
+#include "url/gurl.h"
namespace prerender {
@@ -43,46 +35,16 @@ void ReportPrerenderSchemeCancelReason(PrerenderSchemeCancelReason reason) {
} // namespace
-bool MaybeGetQueryStringBasedAliasURL(
- const GURL& url, GURL* alias_url) {
- DCHECK(alias_url);
- url::Parsed parsed;
- url::ParseStandardURL(url.spec().c_str(), url.spec().length(), &parsed);
- url::Component query = parsed.query;
- url::Component key, value;
- while (url::ExtractQueryKeyValue(url.spec().c_str(), &query, &key, &value)) {
- if (key.len != 3 || strncmp(url.spec().c_str() + key.begin, "url", key.len))
- continue;
- // We found a url= query string component.
- if (value.len < 1)
- continue;
- url::RawCanonOutputW<1024> decoded_url;
- url::DecodeURLEscapeSequences(url.spec().c_str() + value.begin, value.len,
- &decoded_url);
- GURL new_url(base::string16(decoded_url.data(), decoded_url.length()));
- if (!new_url.is_empty() && new_url.is_valid()) {
- *alias_url = new_url;
- return true;
- }
+bool IsGoogleOriginURL(const GURL& origin_url) {
+ // ALLOW_NON_STANDARD_PORTS for integration tests with the embedded server.
+ if (!google_util::IsGoogleDomainUrl(origin_url,
+ google_util::DISALLOW_SUBDOMAIN,
+ google_util::ALLOW_NON_STANDARD_PORTS)) {
return false;
}
- return false;
-}
-
-bool IsGoogleDomain(const GURL& url) {
- return base::StartsWith(url.host_piece(), "www.google.",
- base::CompareCase::SENSITIVE);
-}
-bool IsGoogleSearchResultURL(const GURL& url) {
- if (!IsGoogleDomain(url))
- return false;
- return (url.path_piece().empty() ||
- base::StartsWith(url.path_piece(), "/search",
- base::CompareCase::SENSITIVE) ||
- (url.path_piece() == "/") ||
- base::StartsWith(url.path_piece(), "/webhp",
- base::CompareCase::SENSITIVE));
+ return (origin_url.path_piece() == "/") ||
+ google_util::IsGoogleSearchUrl(origin_url);
}
void ReportPrerenderExternalURL() {
« no previous file with comments | « chrome/browser/prerender/prerender_util.h ('k') | chrome/browser/prerender/prerender_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698