Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: chrome/browser/prerender/prerender_histograms.cc

Issue 2645713003: [Prerender] Cleanup prerender_util (Closed)
Patch Set: Review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_histograms.cc
diff --git a/chrome/browser/prerender/prerender_histograms.cc b/chrome/browser/prerender/prerender_histograms.cc
index d7ea7309607e65c57d8c91aa51bf9107d45037cc..131f17069fa54ab44ce4d47a3eaaa8a210643866 100644
--- a/chrome/browser/prerender/prerender_histograms.cc
+++ b/chrome/browser/prerender/prerender_histograms.cc
@@ -13,7 +13,7 @@
#include "base/metrics/histogram_macros.h"
#include "base/strings/stringprintf.h"
#include "chrome/browser/prerender/prerender_manager.h"
-#include "chrome/browser/prerender/prerender_util.h"
+#include "components/google/core/browser/google_util.h"
#include "net/http/http_cache.h"
namespace prerender {
@@ -266,7 +266,9 @@ void PrerenderHistograms::RecordPerceivedPageLoadTime(
if (!url.SchemeIsHTTPOrHTTPS())
return;
bool within_window = WithinWindow();
- bool is_google_url = IsGoogleDomain(url);
+ bool is_google_url =
+ google_util::IsGoogleDomainUrl(url, google_util::DISALLOW_SUBDOMAIN,
+ google_util::ALLOW_NON_STANDARD_PORTS);
RECORD_PLT("PerceivedPLT", perceived_page_load_time);
if (within_window)
RECORD_PLT("PerceivedPLTWindowed", perceived_page_load_time);
@@ -322,8 +324,11 @@ void PrerenderHistograms::RecordPageLoadTimeNotSwappedIn(
const GURL& url) const {
// If the URL to be prerendered is not a http[s] URL, or is a Google URL,
// do not record.
- if (!url.SchemeIsHTTPOrHTTPS() || IsGoogleDomain(url))
+ if (!url.SchemeIsHTTPOrHTTPS() ||
+ google_util::IsGoogleDomainUrl(url, google_util::DISALLOW_SUBDOMAIN,
+ google_util::ALLOW_NON_STANDARD_PORTS)) {
return;
+ }
RECORD_PLT("PrerenderNotSwappedInPLT", page_load_time);
}
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698