chrome/test/data/prerender/prerender_loader_with_replace_state.html - Issue 2645713003: [Prerender] Cleanup prerender_util

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/prerender/prerender_loader_with_replace_state.html

Issue 2645713003: [Prerender] Cleanup prerender_util (Closed)

Patch Set: ALLOW_NON_STANDARD_PORTS Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <title>Preloader</title>	3 <title>Preloader</title>

4 <script src="prerender_events_common.js"></script>	4 <script src="prerender_events_common.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <script>	7 <script>

8 history.replaceState(null, "Preloader", "/search");	8 history.replaceState(null, "Preloader", "/");
	mattcary 2017/01/20 13:24:21 What's going on here? What's going on here? droger 2017/01/20 13:41:39 www.google.com/search is actually not a valid sear Show quoted text On 2017/01/20 13:24:21, mattcary wrote: > What's going on here? www.google.com/search is actually not a valid search URL. It has to either have a query parameter, like: www.google.com/search?q=hi or the empty path www.google.com/ However, because of the embedded server the URL would actually look like www.google.com:49054/search?q=hi It would actually not work here in the test, because there is still a non-standard port check that I could not remove in this case. So I went with the empty path, which specifically allows non standard ports. The cleaner way would be to inject the "IsGoogleSearchUrl()" function somewhere, so that production code would disallow non-standard port, but tests would allow it.
9 AddPrerender('REPLACE_WITH_PRERENDER_URL', 0);	9 AddPrerender('REPLACE_WITH_PRERENDER_URL', 0);

10 </script>	10 </script>

11 </body>	11 </body>

12 </html>	12 </html>

OLD	NEW